summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAndy Shaw <andy.shaw@qt.io>2021-02-23 09:28:05 +0100
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2021-02-23 12:19:44 +0000
commiteb7bca1edcdd229b92c5d013847492a882194e1f (patch)
tree345d308e55632222916bc6a164ec3188a5cc55a0 /src
parent9ac57c36d42d083d1767353c7eb817d96817d22e (diff)
Only create the GLXYSeriesData if there is no existing data
This ensures that there is no memory leak due to unnecessary creation of the GLXYSeriesData when setting the series data. Change-Id: Iec7966bbbf53e595ead780462c89bb3e1205854e Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> (cherry picked from commit eaf63689403df7f122591795d80ef126b8fb5eaa) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src')
-rw-r--r--src/chartsqml2/declarativeopenglrendernode.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/chartsqml2/declarativeopenglrendernode.cpp b/src/chartsqml2/declarativeopenglrendernode.cpp
index 6d2baf20..013cbe4f 100644
--- a/src/chartsqml2/declarativeopenglrendernode.cpp
+++ b/src/chartsqml2/declarativeopenglrendernode.cpp
@@ -229,7 +229,8 @@ void DeclarativeOpenGLRenderNode::setSeriesData(bool mapDirty, const GLXYDataMap
GLXYSeriesData *data = oldMap.take(i.key());
const GLXYSeriesData *newData = i.value();
if (!data || newData->dirty) {
- data = new GLXYSeriesData;
+ if (!data)
+ data = new GLXYSeriesData;
*data = *newData;
}
m_xyDataMap.insert(i.key(), data);