Eradicate Java-style iterators and mark the module free of them

Java-style iterators are scheduled for deprecation, or at the very
least banned from use in Qt code.

Change-Id: If50aade7e5a57f247ec8c0e77103dfd2d2160c3c
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
 

1 files changed, 10 insertions, 15 deletions

diff --git a/examples/bluetooth/btfiletransfer/remoteselector.cpp b/examples/bluetooth/btfiletransfer/remoteselector.cpp
index 766bd028..b3c60cb3 100644
--- a/examples/bluetooth/btfiletransfer/remoteselector.cpp
+++ b/examples/bluetooth/btfiletransfer/remoteselector.cpp
@@ -171,18 +171,17 @@ void RemoteSelector::serviceDiscovered(const QBluetoothServiceInfo &serviceInfo)
 //        new QListWidgetItem(QString::fromLatin1("%1\t%2\t%3").arg(serviceInfo.device().address().toString(),
 //                                                             serviceInfo.device().name(), serviceInfo.serviceName()));
 
-    QMutableMapIterator<int, QBluetoothServiceInfo> i(m_discoveredServices);
-    while (i.hasNext()){
-        i.next();
-        if (serviceInfo.device().address() == i.value().device().address()){
-            i.setValue(serviceInfo);
+    const QBluetoothAddress address = serviceInfo.device().address();
+    for (QBluetoothServiceInfo &info : m_discoveredServices) {
+        if (info.device().address() == address){
+            info = serviceInfo;
             return;
         }
     }
 
     int row = ui->remoteDevices->rowCount();
     ui->remoteDevices->insertRow(row);
-    QTableWidgetItem *item = new QTableWidgetItem(serviceInfo.device().address().toString());
+    QTableWidgetItem *item = new QTableWidgetItem(address.toString());
     ui->remoteDevices->setItem(row, 0, item);
     item = new QTableWidgetItem(serviceInfo.device().name());
     ui->remoteDevices->setItem(row, 1, item);
@@ -190,9 +189,7 @@ void RemoteSelector::serviceDiscovered(const QBluetoothServiceInfo &serviceInfo)
 
     ui->remoteDevices->setItem(row, 2, item);
 
-    QBluetoothLocalDevice::Pairing p;
-
-    p = m_localDevice->pairingStatus(serviceInfo.device().address());
+    QBluetoothLocalDevice::Pairing p = m_localDevice->pairingStatus(address);
 
     ui->remoteDevices->blockSignals(true);
 
@@ -275,13 +272,11 @@ void RemoteSelector::on_stopButton_clicked()
     m_discoveryAgent->stop();
 }
 
-QString RemoteSelector::addressToName(const QBluetoothAddress &address)
+QString RemoteSelector::addressToName(const QBluetoothAddress &address) const
 {
-    QMapIterator<int, QBluetoothServiceInfo> i(m_discoveredServices);
-    while (i.hasNext()){
-        i.next();
-        if (i.value().device().address() == address)
-            return i.value().device().name();
+    for (const QBluetoothServiceInfo &info : m_discoveredServices) {
+        if (info.device().address() == address)
+            return info.device().name();
     }
     return address.toString();
 }