From a0ade068004ad869d6235ae8d6cd5e2050bf765d Mon Sep 17 00:00:00 2001
From: Oliver Wolff <oliver.wolff@qt.io>
Date: Tue, 14 Aug 2018 11:08:18 +0200
Subject: Replace foreach with for loop and set QT_NO_FOREACH

To avoid unnecessary copies, const is used wherever possible.

Change-Id: Ic743716512751cfd24fad5bd37c244b115dd26fe
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
---
 src/bluetooth/qlowenergycontroller_osx.mm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

(limited to 'src/bluetooth/qlowenergycontroller_osx.mm')

diff --git a/src/bluetooth/qlowenergycontroller_osx.mm b/src/bluetooth/qlowenergycontroller_osx.mm
index 2958e6ed..46782a22 100644
--- a/src/bluetooth/qlowenergycontroller_osx.mm
+++ b/src/bluetooth/qlowenergycontroller_osx.mm
@@ -880,7 +880,9 @@ quint16 QLowEnergyControllerPrivateOSX::updateValueOfDescriptor(QLowEnergyHandle
 
 QSharedPointer<QLowEnergyServicePrivate> QLowEnergyControllerPrivateOSX::serviceForHandle(QLowEnergyHandle handle)
 {
-    foreach (QSharedPointer<QLowEnergyServicePrivate> service, discoveredServices.values()) {
+    const QList<QSharedPointer<QLowEnergyServicePrivate>> services
+            = discoveredServices.values();
+    for (QSharedPointer<QLowEnergyServicePrivate> service : services) {
         if (service->startHandle <= handle && handle <= service->endHandle)
             return service;
     }
@@ -963,7 +965,9 @@ void QLowEnergyControllerPrivateOSX::setErrorDescription(QLowEnergyController::E
 
 void QLowEnergyControllerPrivateOSX::invalidateServices()
 {
-    foreach (const QSharedPointer<QLowEnergyServicePrivate> service, discoveredServices.values()) {
+    const QList<QSharedPointer<QLowEnergyServicePrivate>> services
+            = discoveredServices.values();
+    for (const QSharedPointer<QLowEnergyServicePrivate> service : services) {
         service->setController(nullptr);
         service->setState(QLowEnergyService::InvalidService);
     }
-- 
cgit v1.2.3