Fix: change signals to take values by const ref

Changed signals in declaratives to take their
arguments as const ref when suitable.

Pick-to: 6.1 6.2
Fixes: QTBUG-95941
Change-Id: I3d582422793ee2bfb4cb5251dcacd55d3d3acca9
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>

9 files changed, 12 insertions, 12 deletions

diff --git a/examples/datavisualization/bars/graphmodifier.h b/examples/datavisualization/bars/graphmodifier.h
index b1420e33..4611cc43 100644
--- a/examples/datavisualization/bars/graphmodifier.h
+++ b/examples/datavisualization/bars/graphmodifier.h
@@ -77,7 +77,7 @@ Q_SIGNALS:
     void shadowQualityChanged(int quality);
     void backgroundEnabledChanged(bool enabled);
     void gridEnabledChanged(bool enabled);
-    void fontChanged(QFont font);
+    void fontChanged(const QFont &font);
     void fontSizeChanged(int size);
 
 private:
diff --git a/examples/datavisualization/scatter/scatterdatamodifier.h b/examples/datavisualization/scatter/scatterdatamodifier.h
index cbb14995..f79a46e9 100644
--- a/examples/datavisualization/scatter/scatterdatamodifier.h
+++ b/examples/datavisualization/scatter/scatterdatamodifier.h
@@ -63,7 +63,7 @@ Q_SIGNALS:
     void backgroundEnabledChanged(bool enabled);
     void gridEnabledChanged(bool enabled);
     void shadowQualityChanged(int quality);
-    void fontChanged(QFont font);
+    void fontChanged(const QFont &font);
 
 private:
     QVector3D randVector();
diff --git a/src/datavisualization/engine/q3dcamera_p.h b/src/datavisualization/engine/q3dcamera_p.h
index 944e408e..27685a43 100644
--- a/src/datavisualization/engine/q3dcamera_p.h
+++ b/src/datavisualization/engine/q3dcamera_p.h
@@ -89,7 +89,7 @@ Q_SIGNALS:
     void minYRotationChanged(float rotation);
     void maxXRotationChanged(float rotation);
     void maxYRotationChanged(float rotation);
-    void viewMatrixChanged(QMatrix4x4 viewMatrix);
+    void viewMatrixChanged(const QMatrix4x4 &viewMatrix);
     void viewMatrixAutoUpdateChanged(bool enabled);
 
 public:
diff --git a/src/datavisualizationqml/colorgradient_p.h b/src/datavisualizationqml/colorgradient_p.h
index ec21cd2f..4bae9c1d 100644
--- a/src/datavisualizationqml/colorgradient_p.h
+++ b/src/datavisualizationqml/colorgradient_p.h
@@ -67,7 +67,7 @@ public:
 
 Q_SIGNALS:
     void positionChanged(qreal position);
-    void colorChanged(QColor color);
+    void colorChanged(const QColor &color);
 
 private:
     void updateGradient();
diff --git a/src/datavisualizationqml/declarativebars_p.h b/src/datavisualizationqml/declarativebars_p.h
index d63eafc1..516ff13f 100644
--- a/src/datavisualizationqml/declarativebars_p.h
+++ b/src/datavisualizationqml/declarativebars_p.h
@@ -118,10 +118,10 @@ Q_SIGNALS:
     void columnAxisChanged(QCategory3DAxis *axis);
     void multiSeriesUniformChanged(bool uniform);
     void barThicknessChanged(float thicknessRatio);
-    void barSpacingChanged(QSizeF spacing);
+    void barSpacingChanged(const QSizeF &spacing);
     void barSpacingRelativeChanged(bool relative);
-    Q_REVISION(6, 3) void barSeriesMarginChanged(QSizeF margin);
-    void meshFileNameChanged(QString filename);
+    Q_REVISION(6, 3) void barSeriesMarginChanged(const QSizeF &margin);
+    void meshFileNameChanged(const QString &filename);
     void primarySeriesChanged(QBar3DSeries *series);
     void selectedSeriesChanged(QBar3DSeries *series);
     Q_REVISION(1, 2) void floorLevelChanged(float level);
diff --git a/src/datavisualizationqml/declarativecolor_p.h b/src/datavisualizationqml/declarativecolor_p.h
index d197fcf6..d772e642 100644
--- a/src/datavisualizationqml/declarativecolor_p.h
+++ b/src/datavisualizationqml/declarativecolor_p.h
@@ -61,7 +61,7 @@ public:
     QColor color() const;
 
 Q_SIGNALS:
-    void colorChanged(QColor color);
+    void colorChanged(const QColor &color);
 
 private:
     QColor m_color;
diff --git a/src/datavisualizationqml/declarativescene_p.h b/src/datavisualizationqml/declarativescene_p.h
index 26591d43..eade98aa 100644
--- a/src/datavisualizationqml/declarativescene_p.h
+++ b/src/datavisualizationqml/declarativescene_p.h
@@ -68,7 +68,7 @@ public:
     QPoint invalidSelectionPoint() const;
 
 Q_SIGNALS:
-    void selectionQueryPositionChanged(const QPointF position);
+    void selectionQueryPositionChanged(const QPointF &position);
 };
 
 QT_END_NAMESPACE
diff --git a/src/datavisualizationqml/declarativeseries_p.h b/src/datavisualizationqml/declarativeseries_p.h
index 115e67e0..da45cb3f 100644
--- a/src/datavisualizationqml/declarativeseries_p.h
+++ b/src/datavisualizationqml/declarativeseries_p.h
@@ -97,7 +97,7 @@ public Q_SLOTS:
     void handleMultiHighlightGradientUpdate();
 
 Q_SIGNALS:
-    void selectedBarChanged(QPointF position);
+    void selectedBarChanged(const QPointF &position);
     void baseGradientChanged(ColorGradient *gradient);
     void singleHighlightGradientChanged(ColorGradient *gradient);
     void multiHighlightGradientChanged(ColorGradient *gradient);
@@ -195,7 +195,7 @@ public Q_SLOTS:
     void handleMultiHighlightGradientUpdate();
 
 Q_SIGNALS:
-    void selectedPointChanged(QPointF position);
+    void selectedPointChanged(const QPointF &position);
     void baseGradientChanged(ColorGradient *gradient);
     void singleHighlightGradientChanged(ColorGradient *gradient);
     void multiHighlightGradientChanged(ColorGradient *gradient);
diff --git a/tests/manual/directional/scatterdatamodifier.h b/tests/manual/directional/scatterdatamodifier.h
index 7ca463c3..3120b6f6 100644
--- a/tests/manual/directional/scatterdatamodifier.h
+++ b/tests/manual/directional/scatterdatamodifier.h
@@ -65,7 +65,7 @@ Q_SIGNALS:
     void backgroundEnabledChanged(bool enabled);
     void gridEnabledChanged(bool enabled);
     void shadowQualityChanged(int quality);
-    void fontChanged(QFont font);
+    void fontChanged(const QFont &font);
 
 private:
     Q3DScatter *m_graph;