diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-03-01 21:29:14 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-03-02 08:44:43 +0000 |
| commit | 3661b135306f00e3e4dede8181e0015bcc60d5be (patch) | |
| tree | 1bd78cc89a6b9f565c1b7aefe58878a7556abc23 /examples/datavisualization/graphgallery/scatterdatamodifier.cpp | |
| parent | 29b99b3efc324290a12ee02c748f9c1240f9733c (diff) | |
graphgallery example: Fix leaking modifier classes
The modifier classes were leaking. Pass a parent to ensure their
destruction. Remove the deletion of the graphs from their
destructors since they are QWindows, which are deleted by QtGui.
Task-number: QTBUG-110698
Change-Id: Ied32dad62c93b730f63fa95994c4fc281254c800
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit f289b0b14d174d7c891a225c4e81f67573d8c555)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'examples/datavisualization/graphgallery/scatterdatamodifier.cpp')
| -rw-r--r-- | examples/datavisualization/graphgallery/scatterdatamodifier.cpp | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/examples/datavisualization/graphgallery/scatterdatamodifier.cpp b/examples/datavisualization/graphgallery/scatterdatamodifier.cpp index 93c844c9..f018c81b 100644 --- a/examples/datavisualization/graphgallery/scatterdatamodifier.cpp +++ b/examples/datavisualization/graphgallery/scatterdatamodifier.cpp @@ -21,8 +21,9 @@ const float curveDivider = 7.5f; const int lowerNumberOfItems = 900; const float lowerCurveDivider = 0.75f; -ScatterDataModifier::ScatterDataModifier(Q3DScatter *scatter) - : m_graph(scatter), +ScatterDataModifier::ScatterDataModifier(Q3DScatter *scatter, QObject *parent) : + QObject(parent), + m_graph(scatter), m_itemCount(lowerNumberOfItems), m_curveDivider(lowerCurveDivider), //! [7] @@ -59,11 +60,6 @@ ScatterDataModifier::ScatterDataModifier(Q3DScatter *scatter) //! [2] } -ScatterDataModifier::~ScatterDataModifier() -{ - delete m_graph; -} - void ScatterDataModifier::addData() { // Configure the axes according to the data |