8 files changed, 14 insertions, 11 deletions
diff --git a/src/datavisualizationqml2/CMakeLists.txt b/src/datavisualizationqml2/CMakeLists.txt
index fc7ff7d0..a752306a 100644
--- a/src/datavisualizationqml2/CMakeLists.txt
+++ b/src/datavisualizationqml2/CMakeLists.txt
@@ -60,7 +60,7 @@ qt_internal_add_qml_module(DataVisualizationQml2
         ${qml_files}
     RESOURCES
         ${resources}
-    PUBLIC_LIBRARIES
+    LIBRARIES
         Qt::Core
         Qt::Gui
         Qt::OpenGL
diff --git a/src/datavisualizationqml2/abstractdeclarative.cpp b/src/datavisualizationqml2/abstractdeclarative.cpp
index dbbd803d..890ea324 100644
--- a/src/datavisualizationqml2/abstractdeclarative.cpp
+++ b/src/datavisualizationqml2/abstractdeclarative.cpp
@@ -66,8 +66,11 @@ AbstractDeclarative::AbstractDeclarative(QQuickItem *parent) :
     connect(this, &QQuickItem::windowChanged, this, &AbstractDeclarative::handleWindowChanged);
 
     // Set contents to false in case we are in qml designer to make component look nice
-    m_runningInDesigner = QGuiApplication::applicationDisplayName() == "Qml2Puppet";
+    m_runningInDesigner = QGuiApplication::applicationDisplayName() == QLatin1String("Qml2Puppet");
     setFlag(ItemHasContents, !m_runningInDesigner);
+
+    // Accept touchevents
+    setAcceptTouchEvents(true);
 }
 
 AbstractDeclarative::~AbstractDeclarative()
diff --git a/src/datavisualizationqml2/colorgradient_p.h b/src/datavisualizationqml2/colorgradient_p.h
index 3e5162a7..bdec6469 100644
--- a/src/datavisualizationqml2/colorgradient_p.h
+++ b/src/datavisualizationqml2/colorgradient_p.h
@@ -64,7 +64,7 @@ public:
 
 Q_SIGNALS:
     void positionChanged(qreal position);
-    void colorChanged(QColor color);
+    void colorChanged(const QColor &color);
 
 private:
     void updateGradient();
diff --git a/src/datavisualizationqml2/declarativebars.cpp b/src/datavisualizationqml2/declarativebars.cpp
index fe90e159..8ac2888c 100644
--- a/src/datavisualizationqml2/declarativebars.cpp
+++ b/src/datavisualizationqml2/declarativebars.cpp
@@ -112,7 +112,7 @@ float DeclarativeBars::barThickness() const
     return m_barsController->barThickness();
 }
 
-void DeclarativeBars::setBarSpacing(QSizeF spacing)
+void DeclarativeBars::setBarSpacing(const QSizeF &spacing)
 {
     if (spacing != barSpacing()) {
         m_barsController->setBarSpecs(GLfloat(barThickness()), spacing, isBarSpacingRelative());
diff --git a/src/datavisualizationqml2/declarativebars_p.h b/src/datavisualizationqml2/declarativebars_p.h
index 97359ede..fb75a40b 100644
--- a/src/datavisualizationqml2/declarativebars_p.h
+++ b/src/datavisualizationqml2/declarativebars_p.h
@@ -79,7 +79,7 @@ public:
     void setBarThickness(float thicknessRatio);
     float barThickness() const;
 
-    void setBarSpacing(QSizeF spacing);
+    void setBarSpacing(const QSizeF &spacing);
     QSizeF barSpacing() const;
 
     void setBarSpacingRelative(bool relative);
@@ -111,9 +111,9 @@ Q_SIGNALS:
     void columnAxisChanged(QCategory3DAxis *axis);
     void multiSeriesUniformChanged(bool uniform);
     void barThicknessChanged(float thicknessRatio);
-    void barSpacingChanged(QSizeF spacing);
+    void barSpacingChanged(const QSizeF &spacing);
     void barSpacingRelativeChanged(bool relative);
-    void meshFileNameChanged(QString filename);
+    void meshFileNameChanged(const QString &filename);
     void primarySeriesChanged(QBar3DSeries *series);
     void selectedSeriesChanged(QBar3DSeries *series);
     Q_REVISION(1) void floorLevelChanged(float level);
diff --git a/src/datavisualizationqml2/declarativecolor_p.h b/src/datavisualizationqml2/declarativecolor_p.h
index 54be5397..c4e3a30d 100644
--- a/src/datavisualizationqml2/declarativecolor_p.h
+++ b/src/datavisualizationqml2/declarativecolor_p.h
@@ -57,7 +57,7 @@ public:
     QColor color() const;
 
 Q_SIGNALS:
-    void colorChanged(QColor color);
+    void colorChanged(const QColor &color);
 
 private:
     QColor m_color;
diff --git a/src/datavisualizationqml2/declarativescene_p.h b/src/datavisualizationqml2/declarativescene_p.h
index 70e3da82..5fd8ae22 100644
--- a/src/datavisualizationqml2/declarativescene_p.h
+++ b/src/datavisualizationqml2/declarativescene_p.h
@@ -63,7 +63,7 @@ public:
     QPoint invalidSelectionPoint() const;
 
 Q_SIGNALS:
-    void selectionQueryPositionChanged(const QPointF position);
+    void selectionQueryPositionChanged(const QPointF &position);
 };
 
 QT_END_NAMESPACE
diff --git a/src/datavisualizationqml2/declarativeseries_p.h b/src/datavisualizationqml2/declarativeseries_p.h
index 5f5a535a..18631b85 100644
--- a/src/datavisualizationqml2/declarativeseries_p.h
+++ b/src/datavisualizationqml2/declarativeseries_p.h
@@ -93,7 +93,7 @@ public Q_SLOTS:
     void handleMultiHighlightGradientUpdate();
 
 Q_SIGNALS:
-    void selectedBarChanged(QPointF position);
+    void selectedBarChanged(const QPointF &position);
     void baseGradientChanged(ColorGradient *gradient);
     void singleHighlightGradientChanged(ColorGradient *gradient);
     void multiHighlightGradientChanged(ColorGradient *gradient);
@@ -185,7 +185,7 @@ public Q_SLOTS:
     void handleMultiHighlightGradientUpdate();
 
 Q_SIGNALS:
-    void selectedPointChanged(QPointF position);
+    void selectedPointChanged(const QPointF &position);
     void baseGradientChanged(ColorGradient *gradient);
     void singleHighlightGradientChanged(ColorGradient *gradient);
     void multiHighlightGradientChanged(ColorGradient *gradient);