From 502857f03fc79ba8997e18c012257dc5c020d7cf Mon Sep 17 00:00:00 2001 From: Tomi Korpipaa Date: Wed, 10 Feb 2021 10:35:00 +0200 Subject: Fix macOS build that has -Wunused-function as error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Clang may interpret static inline function as unused, although it should not. Pragma it out for clang. Fixes: QTBUG-91053 Change-Id: I8fd8bec5236752189deff8a2f6ceb62e572dca30 Reviewed-by: Antti Määttä (cherry picked from commit 21ab254164ab0891e12dbd037fc4e163ff9f6e9d) Reviewed-by: Tomi Korpipää --- src/datavisualization/doc/src/qtdatavisualization.qdoc | 2 +- src/datavisualization/engine/qabstract3dgraph.cpp | 2 +- src/datavisualization/utils/qutils.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/datavisualization/doc/src/qtdatavisualization.qdoc b/src/datavisualization/doc/src/qtdatavisualization.qdoc index 0f368616..d1b16a88 100644 --- a/src/datavisualization/doc/src/qtdatavisualization.qdoc +++ b/src/datavisualization/doc/src/qtdatavisualization.qdoc @@ -268,7 +268,7 @@ * // ... * * QQuickView viewer; - * viewer.setFormat(QtDataVisualization::qDefaultSurfaceFormat()); + * viewer.setFormat(QtDataVisualization::qDefaultSurfaceFormat(true)); * \endcode * * \note Antialiasing is not supported in OpenGL ES2 environments. diff --git a/src/datavisualization/engine/qabstract3dgraph.cpp b/src/datavisualization/engine/qabstract3dgraph.cpp index b1bb3a61..c6f22ebe 100644 --- a/src/datavisualization/engine/qabstract3dgraph.cpp +++ b/src/datavisualization/engine/qabstract3dgraph.cpp @@ -186,7 +186,7 @@ QAbstract3DGraph::QAbstract3DGraph(QAbstract3DGraphPrivate *d, const QSurfaceFor // Make sure renderable type is correct surfaceFormat.setRenderableType(QSurfaceFormat::DefaultRenderableType); } else { - surfaceFormat = qDefaultSurfaceFormat(); + surfaceFormat = qDefaultSurfaceFormat(true); } d_ptr->m_context = new QOpenGLContext(this); diff --git a/src/datavisualization/utils/qutils.h b/src/datavisualization/utils/qutils.h index 87bc0f33..dc72835e 100644 --- a/src/datavisualization/utils/qutils.h +++ b/src/datavisualization/utils/qutils.h @@ -38,8 +38,8 @@ QT_BEGIN_NAMESPACE -#ifndef Q_QDOC -static inline QSurfaceFormat qDefaultSurfaceFormat(bool antialias = true); +#ifdef Q_OS_MACOS +#pragma clang diagnostic ignored "-Wunused-function" #endif static inline QSurfaceFormat qDefaultSurfaceFormat(bool antialias) { -- cgit v1.2.3