diff options
authorNils Jeisecke <nils.jeisecke@saltation.com>2018-04-10 15:18:10 +0200
committerShawn Rutledge <shawn.rutledge@qt.io>2018-06-19 12:17:09 +0000
commitb0c79a8bf41d3ae79c23e53afdcdba92ec0ec0b5 (patch)
parent5100d558742c682d83e0d4033d78ed4c9f521f56 (diff)
Flickable: fix another possible cause for out-of-sync moving flags
In addition to d868bb4f3e4b0424fd4a2989ff1c82692b0f014c this removes the check for scrollingPhase in movementEnding. If movementEnding is invoked by some codepath other than timerEvent (e.g. setContentY) and scrollingPhase is true this will again prevent any further invocation of movementStarting from within the drag method (see d868bb4). As this check was introduced together with the movementEnding timer (QTBUG-63026) and scrollingPhase is now checked inside the timerEvent there should be no need for the check in movementEnding. Task-number: QTBUG-67460 Change-Id: I88ad6e3ee56b88a66bb61798b8876324f4842f1e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
1 files changed, 2 insertions, 4 deletions
diff --git a/src/quick/items/qquickflickable.cpp b/src/quick/items/qquickflickable.cpp
index 9c775f7e93..d11f6ea720 100644
--- a/src/quick/items/qquickflickable.cpp
+++ b/src/quick/items/qquickflickable.cpp
@@ -2678,15 +2678,13 @@ void QQuickFlickable::movementEnding(bool hMovementEnding, bool vMovementEnding)
if (hMovementEnding && d->hData.moving
&& (!d->pressed && !d->stealMouse)) {
d->hData.moving = false;
- if (!d->scrollingPhase)
- d->hMoved = false;
+ d->hMoved = false;
emit movingHorizontallyChanged();
if (vMovementEnding && d->vData.moving
&& (!d->pressed && !d->stealMouse)) {
d->vData.moving = false;
- if (!d->scrollingPhase)
- d->vMoved = false;
+ d->vMoved = false;
emit movingVerticallyChanged();
if (wasMoving && !isMoving()) {