summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@qt.io>2017-02-21 15:40:31 +0100
committerLiang Qi <liang.qi@qt.io>2017-02-21 15:23:00 +0000
commit2a15f6c5de6905b2b0b583c0d37d109eeb94c196 (patch)
tree6fe72e71ddab26bf063ea0eb970cc5f41cf7157f
parentbf1bd3abc9a2d990014fa8be451e0239fe12e198 (diff)
QtQuickTest::mouseEvent(): pass QPointF by referencev5.9.0-alpha1
MSVC 2015 64-bit has some unexplainable issues with a static inline function calling itself recursively, like mouseEvent(MouseClick) does. The QPointF argument, which was previously passed by value, somehow lost its y-coordinate and caused consistent test failures in QQC1 tst_extras/tst_piemenu. I can't explain why this change fixes the issue, but it's a harmless improvement that unblocks the CI. Change-Id: I90dd36a676a21c8124f233e1fa8b3864946a326d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Robin Burchell <robin.burchell@crimson.no> Reviewed-by: Liang Qi <liang.qi@qt.io>
-rw-r--r--src/qmltest/quicktestevent.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qmltest/quicktestevent.cpp b/src/qmltest/quicktestevent.cpp
index 4b1adf5a90..dc7b917bc4 100644
--- a/src/qmltest/quicktestevent.cpp
+++ b/src/qmltest/quicktestevent.cpp
@@ -129,7 +129,7 @@ namespace QtQuickTest
static void mouseEvent(MouseAction action, QWindow *window,
QObject *item, Qt::MouseButton button,
- Qt::KeyboardModifiers stateKey, QPointF _pos, int delay=-1)
+ Qt::KeyboardModifiers stateKey, const QPointF &_pos, int delay=-1)
{
QTEST_ASSERT(window);
QTEST_ASSERT(item);