aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Brasser <michael.brasser@nokia.com>2012-05-14 11:56:36 +1000
committerQt by Nokia <qt-info@nokia.com>2012-05-14 23:44:21 +0200
commitdbcbce68850c388db65c6541705d41c9b5acea15 (patch)
tree9f2308bb2229536a32d93899e71436655ee4317e
parent7eb5f7b3e0630d59bfa7e4e185df6f34c237e584 (diff)
Don't pass the expression string to the signal handler profiler.
Working towards removing the need to store a copy of the expression string in the expression. Author: Christiaan Janssen <christiaan.janssen@nokia.com> Change-Id: I2cedfcf455c9aa4f1fb2ed422533945371038c58 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
-rw-r--r--src/qml/debugger/qqmlprofilerservice_p.h5
-rw-r--r--src/qml/qml/qqmlboundsignal.cpp2
2 files changed, 2 insertions, 5 deletions
diff --git a/src/qml/debugger/qqmlprofilerservice_p.h b/src/qml/debugger/qqmlprofilerservice_p.h
index 576f9811b5..5d1002157b 100644
--- a/src/qml/debugger/qqmlprofilerservice_p.h
+++ b/src/qml/debugger/qqmlprofilerservice_p.h
@@ -212,16 +212,13 @@ struct QQmlBindingProfiler {
};
struct QQmlHandlingSignalProfiler {
- QQmlHandlingSignalProfiler(QObject *object, int index, QQmlBoundSignalExpression *expression)
+ QQmlHandlingSignalProfiler(QQmlBoundSignalExpression *expression)
{
enabled = QQmlProfilerService::instance
? QQmlProfilerService::instance->profilingEnabled() : false;
if (enabled) {
QQmlProfilerService *service = QQmlProfilerService::instance;
service->startRange(QQmlProfilerService::HandlingSignal);
- service->rangeData(QQmlProfilerService::HandlingSignal,
- QLatin1String(object->metaObject()->method(index).methodSignature()) + QLatin1String(": ")
- + expression->expression());
service->rangeLocation(QQmlProfilerService::HandlingSignal,
expression->sourceFile(), expression->lineNumber(),
expression->columnNumber());
diff --git a/src/qml/qml/qqmlboundsignal.cpp b/src/qml/qml/qqmlboundsignal.cpp
index 17237d4b78..b3d07c3a12 100644
--- a/src/qml/qml/qqmlboundsignal.cpp
+++ b/src/qml/qml/qqmlboundsignal.cpp
@@ -289,7 +289,7 @@ void QQmlBoundSignal::subscriptionCallback(QQmlNotifierEndpoint *e, void **a)
if (QQmlDebugService::isDebuggingEnabled())
QV8DebugService::instance()->signalEmitted(QString::fromLatin1(s->m_scope->metaObject()->method(s->m_index).methodSignature()));
- QQmlHandlingSignalProfiler prof(*(s->m_scope), s->m_index, s->m_expression);
+ QQmlHandlingSignalProfiler prof(s->m_expression);
s->setIsEvaluating(true);