diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2020-07-30 15:41:03 +0200 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2020-09-01 16:56:42 +0200 |
| commit | fa031668714cfd7e0df490a8378af2bfc87ea8cf (patch) | |
| tree | 880ed3f1082b32f0f7ecc5a75376697594184ba5 | |
| parent | 47ff10532ebd6c7b0cb62c46b0be3b3d7f6214b8 (diff) | |
V4 Date: pass QDate, QTime by value, not by const reference
They're value types, packaging qint64 and int respectively.
Change-Id: I78a0097f77238751ac3ef9f928537f719a6d05d6
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
| -rw-r--r-- | src/qml/jsruntime/qv4dateobject.cpp | 2 | ||||
| -rw-r--r-- | src/qml/jsruntime/qv4dateobject_p.h | 2 | ||||
| -rw-r--r-- | src/qml/jsruntime/qv4engine.cpp | 2 | ||||
| -rw-r--r-- | src/qml/jsruntime/qv4engine_p.h | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/qml/jsruntime/qv4dateobject.cpp b/src/qml/jsruntime/qv4dateobject.cpp index e75d8bc740..447f5b9661 100644 --- a/src/qml/jsruntime/qv4dateobject.cpp +++ b/src/qml/jsruntime/qv4dateobject.cpp @@ -747,7 +747,7 @@ void Heap::DateObject::init(const QDateTime &date) this->date = date.isValid() ? TimeClip(date.toMSecsSinceEpoch()) : qt_qnan(); } -void Heap::DateObject::init(const QTime &time) +void Heap::DateObject::init(QTime time) { Object::init(); if (!time.isValid()) { diff --git a/src/qml/jsruntime/qv4dateobject_p.h b/src/qml/jsruntime/qv4dateobject_p.h index a87eb92caf..ed589f5b09 100644 --- a/src/qml/jsruntime/qv4dateobject_p.h +++ b/src/qml/jsruntime/qv4dateobject_p.h @@ -75,7 +75,7 @@ struct DateObject : Object { this->date = date.toNumber(); } void init(const QDateTime &date); - void init(const QTime &time); + void init(QTime time); double date; }; diff --git a/src/qml/jsruntime/qv4engine.cpp b/src/qml/jsruntime/qv4engine.cpp index 9cd558590f..7a858ed503 100644 --- a/src/qml/jsruntime/qv4engine.cpp +++ b/src/qml/jsruntime/qv4engine.cpp @@ -968,7 +968,7 @@ Heap::DateObject *ExecutionEngine::newDateObject(const QDateTime &dt) return object->d(); } -Heap::DateObject *ExecutionEngine::newDateObjectFromTime(const QTime &t) +Heap::DateObject *ExecutionEngine::newDateObjectFromTime(QTime t) { Scope scope(this); Scoped<DateObject> object(scope, memoryManager->allocate<DateObject>(t)); diff --git a/src/qml/jsruntime/qv4engine_p.h b/src/qml/jsruntime/qv4engine_p.h index c555730838..92bd3a0627 100644 --- a/src/qml/jsruntime/qv4engine_p.h +++ b/src/qml/jsruntime/qv4engine_p.h @@ -589,7 +589,7 @@ public: Heap::DateObject *newDateObject(const Value &value); Heap::DateObject *newDateObject(const QDateTime &dt); - Heap::DateObject *newDateObjectFromTime(const QTime &t); + Heap::DateObject *newDateObjectFromTime(QTime t); Heap::RegExpObject *newRegExpObject(const QString &pattern, int flags); Heap::RegExpObject *newRegExpObject(RegExp *re); |