aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabian Kosmale <fabian.kosmale@qt.io>2020-03-12 10:26:34 +0100
committerFabian Kosmale <fabian.kosmale@qt.io>2020-03-16 13:39:25 +0100
commit008c8119ee10a453580281c16e4737efe98203e8 (patch)
treea369ca07a4b509955741198704e7942dd092df4f
parentcbd4456c9db70afda6c8408be7e5da800889d169 (diff)
Check that value type exists before creating wrapper
Fixes: QTBUG-82843 Change-Id: I1ea4a52b33e7d318525e63346eab46ecf7a8fec0 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 5bcb2ff883f9f8ceb42ed6de298aa3036d6413b3)
-rw-r--r--src/qml/qml/qqmlvaluetypewrapper.cpp12
1 files changed, 10 insertions, 2 deletions
diff --git a/src/qml/qml/qqmlvaluetypewrapper.cpp b/src/qml/qml/qqmlvaluetypewrapper.cpp
index b22d1530e2..5d7a2130b2 100644
--- a/src/qml/qml/qqmlvaluetypewrapper.cpp
+++ b/src/qml/qml/qqmlvaluetypewrapper.cpp
@@ -192,7 +192,11 @@ ReturnedValue QQmlValueTypeWrapper::create(ExecutionEngine *engine, QObject *obj
r->d()->object = object;
r->d()->property = property;
r->d()->setPropertyCache(QJSEnginePrivate::get(engine)->cache(metaObject));
- r->d()->valueType = QQmlValueTypeFactory::valueType(typeId);
+ auto valueType = QQmlValueTypeFactory::valueType(typeId);
+ if (!valueType) {
+ return engine->throwTypeError(QString::fromLatin1("Type %1 is not a value type").arg(QString::fromLocal8Bit(QMetaType::typeName(typeId))));
+ }
+ r->d()->valueType = valueType;
r->d()->gadgetPtr = nullptr;
return r->asReturnedValue();
}
@@ -204,7 +208,11 @@ ReturnedValue QQmlValueTypeWrapper::create(ExecutionEngine *engine, const QVaria
Scoped<QQmlValueTypeWrapper> r(scope, engine->memoryManager->allocate<QQmlValueTypeWrapper>());
r->d()->setPropertyCache(QJSEnginePrivate::get(engine)->cache(metaObject));
- r->d()->valueType = QQmlValueTypeFactory::valueType(typeId);
+ auto valueType = QQmlValueTypeFactory::valueType(typeId);
+ if (!valueType) {
+ return engine->throwTypeError(QString::fromLatin1("Type %1 is not a value type").arg(QString::fromLocal8Bit(QMetaType::typeName(typeId))));
+ }
+ r->d()->valueType = valueType;
r->d()->gadgetPtr = nullptr;
r->d()->setValue(value);
return r->asReturnedValue();