aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Burchell <robin.burchell@jollamobile.com>2014-08-11 11:23:47 +0200
committerShawn Rutledge <shawn.rutledge@digia.com>2014-08-15 06:15:59 +0200
commit16f2557a2e4fe03bc4feb411e031b7eff78adc0f (patch)
treeb0af83f942955e3ffe2e0ec239a1e4abcded61b0
parentb29fac2d05424fd2263ed2ffdd39d2062007a86b (diff)
tst_dialogs: QTRY_ on the expression (spyVisibilityChanged.count) not the variable.
We only assign to the variable once, so the value may not change in time. Change-Id: I54ac7faad60d3984bfde4606aaf7e30a2340ba3e Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
-rw-r--r--tests/auto/quick/dialogs/tst_dialogs.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/auto/quick/dialogs/tst_dialogs.cpp b/tests/auto/quick/dialogs/tst_dialogs.cpp
index 1ab10cc80f..df3728e714 100644
--- a/tests/auto/quick/dialogs/tst_dialogs.cpp
+++ b/tests/auto/quick/dialogs/tst_dialogs.cpp
@@ -124,8 +124,8 @@ void tst_dialogs::fileDialogNonModal()
dlg->setProperty("modality", QVariant((int)Qt::NonModal));
QSignalSpy spyVisibilityChanged(dlg, SIGNAL(visibilityChanged()));
QTest::mouseClick(window, Qt::LeftButton, 0, QPoint(1000, 100)); // show
+ QTRY_VERIFY(spyVisibilityChanged.count() > 0);
int visibilityChangedCount = spyVisibilityChanged.count();
- QTRY_VERIFY(visibilityChangedCount > 0);
QCOMPARE(dlg->property("visible").toBool(), true);
QTest::mouseClick(window, Qt::LeftButton, 0, QPoint(1000, 100)); // hide
QTRY_VERIFY(spyVisibilityChanged.count() > visibilityChangedCount);