aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVishesh Handa <vhanda@kde.org>2015-03-12 14:26:00 +0100
committerVishesh Handa <vhanda@kde.org>2015-05-20 16:18:10 +0000
commit65a28bb1cd871d9332bc0734bc0a2f1a1e1bbeab (patch)
treea76cb5ec6c1c27cc8d1960771502933314b46efd
parent07882f73e8028577d9223b65a5abd6ffed5d2b35 (diff)
Fix null pointer dereference in QQmlImportNamespace
Change-Id: Iaf61f38790b0dfddb924043e0a25eb8a882571c8 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
-rw-r--r--src/qml/qml/qqmlimport.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/src/qml/qml/qqmlimport.cpp b/src/qml/qml/qqmlimport.cpp
index 906e073cab..5a54609e12 100644
--- a/src/qml/qml/qqmlimport.cpp
+++ b/src/qml/qml/qqmlimport.cpp
@@ -653,9 +653,10 @@ bool QQmlImportNamespace::Import::resolveType(QQmlTypeLoader *typeLoader,
}
if (candidate != end) {
+ QQmlType *returnType = getTypeForUrl(componentUrl, type, isCompositeSingleton, 0);
if (type_return)
- *type_return = getTypeForUrl(componentUrl, type, isCompositeSingleton, 0);
- return (*type_return != 0);
+ *type_return = returnType;
+ return returnType != 0;
}
} else if (!isLibrary) {
QString qmlUrl;
@@ -679,9 +680,10 @@ bool QQmlImportNamespace::Import::resolveType(QQmlTypeLoader *typeLoader,
if (typeRecursionDetected)
*typeRecursionDetected = true;
} else {
+ QQmlType *returnType = getTypeForUrl(qmlUrl, type, false, 0);
if (type_return)
- *type_return = getTypeForUrl(qmlUrl, type, false, 0);
- return (*type_return) != 0;
+ *type_return = returnType;
+ return returnType != 0;
}
}
}