aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTuomo Pelkonen <tuomo.pelkonen@qt.io>2021-09-29 11:44:31 +0300
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2021-10-05 19:06:53 +0000
commitca92e044d884b52c838266e917044a57c34d9e5f (patch)
treed0e3eee5c15e19d325db20a2df1fd35893a0c14c
parentebe36ea115795af79f10310aa624b57b25ea694a (diff)
Avoid giving false warnings of translations not fitting in
Text elements inside layouts give false warnings when they are located inside a layout. For now this is a best solution to avoid false warnings. Task-number: QTBUG-96962 Change-Id: I0c3d1c3e5e245864499a968dc80eda3994b4bee1 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> (cherry picked from commit 1a960362fb14419aa8446b1954f7a16c6d35d11b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/plugins/qmltooling/qmldbg_preview/qqmldebugtranslationservice.cpp8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/plugins/qmltooling/qmldbg_preview/qqmldebugtranslationservice.cpp b/src/plugins/qmltooling/qmldbg_preview/qqmldebugtranslationservice.cpp
index cc2fcc608b..854937f4ae 100644
--- a/src/plugins/qmltooling/qmldbg_preview/qqmldebugtranslationservice.cpp
+++ b/src/plugins/qmltooling/qmldbg_preview/qqmldebugtranslationservice.cpp
@@ -425,7 +425,13 @@ QString QQmlDebugTranslationServiceImpl::foundElidedText(QObject *textObject, co
if (QQuickItem* quickItem = qobject_cast<QQuickItem*>(textObject)) {
const TranslationBindingInformation information = d->objectTranslationBindingMultiMap.value(quickItem);
- if (d->watchTextElides) {
+ QQuickItem* parentItem = quickItem->parentItem();
+ QString parentTypeName = parentItem->metaObject()->className();
+
+ // Currently text fields inside a layout give false signals about elides
+ // so we just omit them
+
+ if (d->watchTextElides && !parentTypeName.endsWith("Layout")) {
d->sendElidedTextWarning(information);
}