aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@nokia.com>2012-06-13 12:09:15 +0200
committerQt by Nokia <qt-info@nokia.com>2012-06-20 17:22:01 +0200
commite884e15615dc97c95704835756680b9c38be29ea (patch)
treec3c6e39879f52a4a5b0349844519c18e8343db3c
parent201173242ed511a86fe636e110589a9c2d91f9db (diff)
QtQuick: Fix warnings about deprecated QWeakPointer usage.
Use QPointer for QObject-derived classes. Change-Id: Ia7be2354b8b3bbce04316185f49a80e76057a18b Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
-rw-r--r--src/quick/items/qquickview_p.h2
-rw-r--r--src/quick/qtquick2.cpp7
2 files changed, 5 insertions, 4 deletions
diff --git a/src/quick/items/qquickview_p.h b/src/quick/items/qquickview_p.h
index 00f7640c10..fcabddda1f 100644
--- a/src/quick/items/qquickview_p.h
+++ b/src/quick/items/qquickview_p.h
@@ -89,7 +89,7 @@ public:
QUrl source;
- QWeakPointer<QQmlEngine> engine;
+ QPointer<QQmlEngine> engine;
QQmlComponent *component;
QBasicTimer resizetimer;
diff --git a/src/quick/qtquick2.cpp b/src/quick/qtquick2.cpp
index 8a0c05618a..ed1fa0da6d 100644
--- a/src/quick/qtquick2.cpp
+++ b/src/quick/qtquick2.cpp
@@ -53,7 +53,7 @@
#include <QtQuick/private/qquickpropertychanges_p.h>
#include <QtQuick/private/qquickstate_p.h>
#include <qqmlproperty.h>
-#include <QtCore/QWeakPointer>
+#include <QtCore/QPointer>
QT_BEGIN_NAMESPACE
@@ -78,7 +78,7 @@ public:
private:
void buildStatesList(QObject *obj);
- QList<QWeakPointer<QQuickState> > m_allStates;
+ QList<QPointer<QQuickState> > m_allStates;
};
QQmlQtQuick2DebugStatesDelegate::QQmlQtQuick2DebugStatesDelegate()
@@ -119,9 +119,10 @@ void QQmlQtQuick2DebugStatesDelegate::updateBinding(QQmlContext *context,
const QString &fileName, int line, int column,
bool *inBaseState)
{
+ typedef QPointer<QQuickState> QuickStatePointer;
QObject *object = property.object();
QString propertyName = property.name();
- foreach (QWeakPointer<QQuickState> statePointer, m_allStates) {
+ foreach (const QuickStatePointer& statePointer, m_allStates) {
if (QQuickState *state = statePointer.data()) {
// here we assume that the revert list on itself defines the base state
if (state->isStateActive() && state->containsPropertyInRevertList(object, propertyName)) {