diff options
author | Vladimir Belyavsky <belyavskyv@gmail.com> | 2024-04-21 20:20:54 +0300 |
---|---|---|
committer | Vladimir Belyavsky <belyavskyv@gmail.com> | 2024-04-22 08:33:54 +0000 |
commit | 2f2345ee4e4af5bfe7749b24b8e85f30ccd97316 (patch) | |
tree | 9da37f103d06254a01de045c66ae631f2c6e97bf | |
parent | 7a222970f56e4396696e82c0113839f61cdd9a83 (diff) |
QSGRhiShaderEffectNode: Avoid unnecessary uniformBlocks list detach
Avoid unnecessary uniformBlocks list detach in
QSGRhiShaderEffectDefaultShader::create() by using QList::constFirst()
instead of non-const QList::first().
Change-Id: Ie97a9d471e7cd00b1a9f32abe29c8500defe899c
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
-rw-r--r-- | src/quick/scenegraph/qsgrhishadereffectnode.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/quick/scenegraph/qsgrhishadereffectnode.cpp b/src/quick/scenegraph/qsgrhishadereffectnode.cpp index 8d80b13f56..c3b7b42cb9 100644 --- a/src/quick/scenegraph/qsgrhishadereffectnode.cpp +++ b/src/quick/scenegraph/qsgrhishadereffectnode.cpp @@ -702,7 +702,7 @@ QSGRhiShaderEffectDefaultShader QSGRhiShaderEffectDefaultShader::create(const QS { QSGRhiShaderEffectDefaultShader s; s.shader = loadShaderFromFile(filename); - const QList<QShaderDescription::BlockVariable> uboMembers = s.shader.description().uniformBlocks().first().members; + const QList<QShaderDescription::BlockVariable> uboMembers = s.shader.description().uniformBlocks().constFirst().members; for (const auto &member: uboMembers) { if (member.name == QByteArrayLiteral("qt_Matrix")) s.matrixArrayByteSize = member.size; |