aboutsummaryrefslogtreecommitdiffstats
path: root/examples/qml/referenceexamples/binding/happybirthdaysong.cpp
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2021-11-02 09:04:21 +0100
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2021-11-04 14:01:08 +0100
commita919ae95d98c6210675e24d6ca683bc60f51d884 (patch)
treeb7a96480298642172089c2721ad24ca1ec4c7550 /examples/qml/referenceexamples/binding/happybirthdaysong.cpp
parentf0511bef9386e33e00ad102b6b955a5b5d7aa4fb (diff)
Polish the QML reference examples
- Use member initialization, which allows for using constructors from the base classes - Use qsizetype for indexes - Use qInfo() instead of qWarning() for printing - Add spaces/fix formatting Change-Id: Iebce1b810ce00f29395207d93303363b3b71e52e Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit c442ed4d65b0319e4abd7a931cfb2f1f72842b84) Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'examples/qml/referenceexamples/binding/happybirthdaysong.cpp')
-rw-r--r--examples/qml/referenceexamples/binding/happybirthdaysong.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/examples/qml/referenceexamples/binding/happybirthdaysong.cpp b/examples/qml/referenceexamples/binding/happybirthdaysong.cpp
index 5f8e6d696e..2722b65e06 100644
--- a/examples/qml/referenceexamples/binding/happybirthdaysong.cpp
+++ b/examples/qml/referenceexamples/binding/happybirthdaysong.cpp
@@ -50,10 +50,9 @@
#include "happybirthdaysong.h"
#include <QTimer>
-HappyBirthdaySong::HappyBirthdaySong(QObject *parent)
-: QObject(parent), m_line(-1)
+HappyBirthdaySong::HappyBirthdaySong(QObject *parent) :
+ QObject(parent)
{
- setName(QString());
auto *timer = new QTimer(this);
QObject::connect(timer, &QTimer::timeout, this, &HappyBirthdaySong::advance);
timer->start(1000);