Micro optimization of StringPool

In destructor we do not need to create a copy off all pointers.

By hiding StringPool::strings in class private
section we reduce risk of it being accidentally copied.

Change-Id: I1b9df6bf9e49bd6926e84b8eac6b3d904277e50a
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/qmljs_engine.cpp b/qmljs_engine.cpp
index 1940a4fa90..78fd64bf7b 100644
--- a/qmljs_engine.cpp
+++ b/qmljs_engine.cpp
@@ -46,12 +46,14 @@
 namespace QQmlJS {
 namespace VM {
 
-struct StringPool
+class StringPool
 {
     QHash<QString, String*> strings;
-
+public:
     ~StringPool()
-    { qDeleteAll(strings.values()); }
+    {
+        qDeleteAll(strings);
+    }
 
     String *newString(const QString &s)
     {