diff options
| author | Simon Hausmann <simon.hausmann@qt.io> | 2018-05-28 09:14:06 +0200 |
|---|---|---|
| committer | Simon Hausmann <simon.hausmann@qt.io> | 2018-05-28 11:46:19 +0000 |
| commit | 1fc9c52e9984e08d32631ed3d61a9c45f2990b36 (patch) | |
| tree | 9381538bd1fcd93b0f5bc053d96c5d6609bb515e /src/3rdparty | |
| parent | 3ccd529e350fdf20ad3fb7b296220d63f8bcc747 (diff) | |
Add comment about use of memfd for JIT memory allocations on Android
Thiago requested a clarifying comment and he's right about that.
Amends 4d9e329df599da96927d559931eabd0062bcf147
Change-Id: Ia9a34eb556da485d51a3d48412a98070fb397ab3
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/3rdparty')
| -rw-r--r-- | src/3rdparty/masm/wtf/OSAllocatorPosix.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/3rdparty/masm/wtf/OSAllocatorPosix.cpp b/src/3rdparty/masm/wtf/OSAllocatorPosix.cpp index cc39364007..3b2a73a39a 100644 --- a/src/3rdparty/masm/wtf/OSAllocatorPosix.cpp +++ b/src/3rdparty/masm/wtf/OSAllocatorPosix.cpp @@ -45,6 +45,9 @@ #endif #if defined(__ANDROID__) && defined(SYS_memfd_create) + // On Android it's been observed that permissions of memory mappings + // backed by a memfd could not be changed via mprotect for no obvious + // reason. # undef SYS_memfd_create #endif |