diff options
author | Kent Hansen <kent.hansen@nokia.com> | 2011-10-12 08:26:22 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-10-17 12:20:11 +0200 |
commit | 7fa3aa4d48c3b7d9bf17b6135bc6bdeb62e899d2 (patch) | |
tree | e5dfde8932ae195d5f1d60e34afaa7f9a27410de /src/declarative/particles | |
parent | cbedc09b7c28c178813371a6cf9c0e7de58f96cc (diff) |
Clean up declarative includes
(This commit is in preparation of moving several files
to a separate library (QtQuick2).)
Don't add all subfolders to the includepath (from the
.pri files). There's no good reason to do that.
For headers (both public and private) that are in the
same folder as the file that includes them, prefer to use
#include "foo.h"
#include "bar_p.h"
For public headers that are outside the current folder
but have "unambiguous" names (e.g. qdeclarative prefix), use
#include <foo.h>
For private headers that are outside the current folder, use
#include <private/baz_p.h>
Also change
#include <QtDeclarative/private/foo_p.h>
to
#include <private/foo_p.h>
The header filenames already have a qdeclarative or qsg
prefix; there's no need to prefix by module name to
disambiguate.
Finally,
#include "private/foo_p.h"
should be avoided. private/ is used for auto-generated
(forwarding) headers, which never reside in the current
(source) directory. Use angle brackets instead.
Change-Id: I04f8477fdba043546064ee276475c09dc373f8f2
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Diffstat (limited to 'src/declarative/particles')
-rw-r--r-- | src/declarative/particles/particles.pri | 2 | ||||
-rw-r--r-- | src/declarative/particles/qsgcustomparticle_p.h | 2 | ||||
-rw-r--r-- | src/declarative/particles/qsggroupgoal.cpp | 4 | ||||
-rw-r--r-- | src/declarative/particles/qsgimageparticle.cpp | 4 | ||||
-rw-r--r-- | src/declarative/particles/qsgitemparticle.cpp | 2 | ||||
-rw-r--r-- | src/declarative/particles/qsgparticlegroup_p.h | 2 | ||||
-rw-r--r-- | src/declarative/particles/qsgparticlesystem.cpp | 4 | ||||
-rw-r--r-- | src/declarative/particles/qsgparticlesystem_p.h | 2 | ||||
-rw-r--r-- | src/declarative/particles/qsgspritegoal.cpp | 4 |
9 files changed, 12 insertions, 14 deletions
diff --git a/src/declarative/particles/particles.pri b/src/declarative/particles/particles.pri index 4502cc499c..a3a8c90d85 100644 --- a/src/declarative/particles/particles.pri +++ b/src/declarative/particles/particles.pri @@ -1,5 +1,3 @@ -INCLUDEPATH += $$PWD - HEADERS += \ $$PWD/qsgangledirection_p.h \ $$PWD/qsgcustomparticle_p.h \ diff --git a/src/declarative/particles/qsgcustomparticle_p.h b/src/declarative/particles/qsgcustomparticle_p.h index db3a78831b..99f63d5178 100644 --- a/src/declarative/particles/qsgcustomparticle_p.h +++ b/src/declarative/particles/qsgcustomparticle_p.h @@ -42,7 +42,7 @@ #ifndef CUSTOM_PARTICLE_H #define CUSTOM_PARTICLE_H #include "qsgparticlepainter_p.h" -#include <QtDeclarative/private/qsgshadereffectnode_p.h> +#include <private/qsgshadereffectnode_p.h> #include <QSignalMapper> QT_BEGIN_HEADER diff --git a/src/declarative/particles/qsggroupgoal.cpp b/src/declarative/particles/qsggroupgoal.cpp index 7f0b938987..f380101bd6 100644 --- a/src/declarative/particles/qsggroupgoal.cpp +++ b/src/declarative/particles/qsggroupgoal.cpp @@ -40,8 +40,8 @@ ****************************************************************************/ #include "qsggroupgoal_p.h" -#include "private/qsgspriteengine_p.h" -#include "private/qsgsprite_p.h" +#include <private/qsgspriteengine_p.h> +#include <private/qsgsprite_p.h> #include "qsgimageparticle_p.h" #include <QDebug> diff --git a/src/declarative/particles/qsgimageparticle.cpp b/src/declarative/particles/qsgimageparticle.cpp index d219fc3df8..02b3a7a92a 100644 --- a/src/declarative/particles/qsgimageparticle.cpp +++ b/src/declarative/particles/qsgimageparticle.cpp @@ -47,8 +47,8 @@ #include <QFile> #include "qsgimageparticle_p.h" #include "qsgparticleemitter_p.h" -#include "qsgsprite_p.h" -#include "qsgspriteengine_p.h" +#include <private/qsgsprite_p.h> +#include <private/qsgspriteengine_p.h> #include <QOpenGLFunctions> #include <qsgengine.h> #include <private/qsgtexture_p.h> diff --git a/src/declarative/particles/qsgitemparticle.cpp b/src/declarative/particles/qsgitemparticle.cpp index 19e64b2cd6..20bd18d146 100644 --- a/src/declarative/particles/qsgitemparticle.cpp +++ b/src/declarative/particles/qsgitemparticle.cpp @@ -40,7 +40,7 @@ ****************************************************************************/ #include "qsgitemparticle_p.h" -#include <QtDeclarative/private/qsgvisualitemmodel_p.h> +#include <private/qsgvisualitemmodel_p.h> #include <qsgnode.h> #include <QTimer> #include <QDeclarativeComponent> diff --git a/src/declarative/particles/qsgparticlegroup_p.h b/src/declarative/particles/qsgparticlegroup_p.h index a809b63e8a..26bed55785 100644 --- a/src/declarative/particles/qsgparticlegroup_p.h +++ b/src/declarative/particles/qsgparticlegroup_p.h @@ -40,7 +40,7 @@ ****************************************************************************/ #ifndef QSGPARTICLEGROUP #define QSGPARTICLEGROUP -#include "qsgspriteengine_p.h" +#include <private/qsgspriteengine_p.h> #include "qsgparticlesystem_p.h" #include "qdeclarativeparserstatus.h" diff --git a/src/declarative/particles/qsgparticlesystem.cpp b/src/declarative/particles/qsgparticlesystem.cpp index fd4b75d7f9..1d4498891f 100644 --- a/src/declarative/particles/qsgparticlesystem.cpp +++ b/src/declarative/particles/qsgparticlesystem.cpp @@ -44,8 +44,8 @@ #include "qsgparticleemitter_p.h" #include "qsgparticleaffector_p.h" #include "qsgparticlepainter_p.h" -#include "qsgspriteengine_p.h" -#include "qsgsprite_p.h" +#include <private/qsgspriteengine_p.h> +#include <private/qsgsprite_p.h> #include "qsgv8particledata_p.h" #include "qsgparticlegroup_p.h" diff --git a/src/declarative/particles/qsgparticlesystem_p.h b/src/declarative/particles/qsgparticlesystem_p.h index 0729727e43..c7399549f4 100644 --- a/src/declarative/particles/qsgparticlesystem_p.h +++ b/src/declarative/particles/qsgparticlesystem_p.h @@ -48,7 +48,7 @@ #include <QHash> #include <QPointer> #include <QSignalMapper> -#include <QtDeclarative/private/qsgsprite_p.h> +#include <private/qsgsprite_p.h> #include <QAbstractAnimation> #include <QtDeclarative/qdeclarative.h> #include <private/qv8engine_p.h> //For QDeclarativeV8Handle diff --git a/src/declarative/particles/qsgspritegoal.cpp b/src/declarative/particles/qsgspritegoal.cpp index 1e8feec672..12d985f0c3 100644 --- a/src/declarative/particles/qsgspritegoal.cpp +++ b/src/declarative/particles/qsgspritegoal.cpp @@ -40,8 +40,8 @@ ****************************************************************************/ #include "qsgspritegoal_p.h" -#include "private/qsgspriteengine_p.h" -#include "private/qsgsprite_p.h" +#include <private/qsgspriteengine_p.h> +#include <private/qsgsprite_p.h> #include "qsgimageparticle_p.h" #include <QDebug> |