diff options
author | Aaron Kennedy <aaron.kennedy@nokia.com> | 2011-06-09 14:40:44 +1000 |
---|---|---|
committer | Aaron Kennedy <aaron.kennedy@nokia.com> | 2011-06-09 14:40:44 +1000 |
commit | 8bb487e60899382f0890fd675eb272d5cc562882 (patch) | |
tree | 7842e975fd36747fcd612dbae2135243ba9ca4d6 /src/declarative/qml/v8/qv8contextwrapper_p.h | |
parent | 4d2e0cebec26b7adcfdad4c4997f7ec22dd72cb8 (diff) |
Minor XXX fixups
Diffstat (limited to 'src/declarative/qml/v8/qv8contextwrapper_p.h')
-rw-r--r-- | src/declarative/qml/v8/qv8contextwrapper_p.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/declarative/qml/v8/qv8contextwrapper_p.h b/src/declarative/qml/v8/qv8contextwrapper_p.h index 3149569285..12e01bab76 100644 --- a/src/declarative/qml/v8/qv8contextwrapper_p.h +++ b/src/declarative/qml/v8/qv8contextwrapper_p.h @@ -79,7 +79,11 @@ public: void addSubContext(v8::Handle<v8::Object> qmlglobal, v8::Handle<v8::Script>, QDeclarativeContextData *ctxt); - // XXX aakenned - remove this abomination + // XXX We only use the secondary scope to pass the "arguments" of the signal to + // on<SignalName> properties. Instead of doing this we should rewrite the + // JavaScript closure function to accept these arguments as named parameters. + // To keep backwards compatibility we have to check that the argument names are + // not members of the QV8Engine::illegalNames() set. QObject *setSecondaryScope(v8::Handle<v8::Object>, QObject *); QDeclarativeContextData *callingContext(); |