aboutsummaryrefslogtreecommitdiffstats
path: root/src/declarative/qml/v8/qv8valuetypewrapper.cpp
diff options
context:
space:
mode:
authorAaron Kennedy <aaron.kennedy@nokia.com>2011-06-09 14:40:44 +1000
committerAaron Kennedy <aaron.kennedy@nokia.com>2011-06-09 14:40:44 +1000
commit8bb487e60899382f0890fd675eb272d5cc562882 (patch)
tree7842e975fd36747fcd612dbae2135243ba9ca4d6 /src/declarative/qml/v8/qv8valuetypewrapper.cpp
parent4d2e0cebec26b7adcfdad4c4997f7ec22dd72cb8 (diff)
Minor XXX fixups
Diffstat (limited to 'src/declarative/qml/v8/qv8valuetypewrapper.cpp')
-rw-r--r--src/declarative/qml/v8/qv8valuetypewrapper.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/declarative/qml/v8/qv8valuetypewrapper.cpp b/src/declarative/qml/v8/qv8valuetypewrapper.cpp
index b16a81e607..f4f79ce92e 100644
--- a/src/declarative/qml/v8/qv8valuetypewrapper.cpp
+++ b/src/declarative/qml/v8/qv8valuetypewrapper.cpp
@@ -117,7 +117,7 @@ void QV8ValueTypeWrapper::init(QV8Engine *engine)
v8::Local<v8::Object> QV8ValueTypeWrapper::newValueType(QObject *object, int property, QDeclarativeValueType *type)
{
- // XXX aakenned - NewInstance() is slow for our case
+ // XXX NewInstance() should be optimized
v8::Local<v8::Object> rv = m_constructor->NewInstance();
QV8ValueTypeReferenceResource *r = new QV8ValueTypeReferenceResource(m_engine);
r->type = type; r->object = object; r->property = property;
@@ -127,7 +127,7 @@ v8::Local<v8::Object> QV8ValueTypeWrapper::newValueType(QObject *object, int pro
v8::Local<v8::Object> QV8ValueTypeWrapper::newValueType(const QVariant &value, QDeclarativeValueType *type)
{
- // XXX aakenned - NewInstance() is slow for our case
+ // XXX NewInstance() should be optimized
v8::Local<v8::Object> rv = m_constructor->NewInstance();
QV8ValueTypeCopyResource *r = new QV8ValueTypeCopyResource(m_engine);
r->type = type; r->value = value;
@@ -172,9 +172,9 @@ v8::Handle<v8::Value> QV8ValueTypeWrapper::Getter(v8::Local<v8::String> property
QV8ValueTypeResource *r = v8_resource_cast<QV8ValueTypeResource>(info.This());
if (!r) return v8::Undefined();
- // XXX aakenned - this is horribly inefficient. People seem to have taken a
- // liking to value type properties, so we should probably try and optimize it
- // a little.
+ // XXX This is horribly inefficient. Sadly people seem to have taken a liking to
+ // value type properties, so we should probably try and optimize it a little.
+ // We should probably just replace all value properties with dedicated accessors.
QByteArray propName = r->engine->toString(property).toUtf8();
int index = r->type->metaObject()->indexOfProperty(propName.constData());