diff options
author | Robin Burchell <robin.burchell@collabora.com> | 2012-01-06 19:20:55 +0100 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-01-12 16:21:35 +0100 |
commit | d402acbc892a8cf447acece100357694188a69e6 (patch) | |
tree | f00e50e5f5bb9ddb8de04cd53401978b1bffcca2 /src/declarative | |
parent | 39f9b5def185337b2087cadeb3e137dfbeb85fa4 (diff) |
Remove out-of-line uses of qMalloc/qFree/qRealloc.
Per http://codereview.qt-project.org/#change,11562, we are trying to remove these
in favour of direct allocation, or (in the case of inline code) specialised
out-of-line wrappers.
Change-Id: I113609c4f97dc5c8020a72cbd398572cdb5b7505
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Diffstat (limited to 'src/declarative')
-rw-r--r-- | src/declarative/qml/parser/qdeclarativejs.g | 16 | ||||
-rw-r--r-- | src/declarative/qml/parser/qdeclarativejsparser.cpp | 16 | ||||
-rw-r--r-- | src/declarative/qml/qdeclarativeboundsignal.cpp | 2 | ||||
-rw-r--r-- | src/declarative/qml/qdeclarativeopenmetaobject.cpp | 4 | ||||
-rw-r--r-- | src/declarative/qml/qdeclarativepropertycache.cpp | 6 |
5 files changed, 22 insertions, 22 deletions
diff --git a/src/declarative/qml/parser/qdeclarativejs.g b/src/declarative/qml/parser/qdeclarativejs.g index f7f92a5d6d..9ed2e86744 100644 --- a/src/declarative/qml/parser/qdeclarativejs.g +++ b/src/declarative/qml/parser/qdeclarativejs.g @@ -398,10 +398,10 @@ void Parser::reallocateStack() else stack_size <<= 1; - sym_stack = reinterpret_cast<Value*> (qRealloc(sym_stack, stack_size * sizeof(Value))); - state_stack = reinterpret_cast<int*> (qRealloc(state_stack, stack_size * sizeof(int))); - location_stack = reinterpret_cast<AST::SourceLocation*> (qRealloc(location_stack, stack_size * sizeof(AST::SourceLocation))); - string_stack = reinterpret_cast<QStringRef*> (qRealloc(string_stack, stack_size * sizeof(QStringRef))); + sym_stack = reinterpret_cast<Value*> (realloc(sym_stack, stack_size * sizeof(Value))); + state_stack = reinterpret_cast<int*> (realloc(state_stack, stack_size * sizeof(int))); + location_stack = reinterpret_cast<AST::SourceLocation*> (realloc(location_stack, stack_size * sizeof(AST::SourceLocation))); + string_stack = reinterpret_cast<QStringRef*> (realloc(string_stack, stack_size * sizeof(QStringRef))); } Parser::Parser(Engine *engine): @@ -421,10 +421,10 @@ Parser::Parser(Engine *engine): Parser::~Parser() { if (stack_size) { - qFree(sym_stack); - qFree(state_stack); - qFree(location_stack); - qFree(string_stack); + free(sym_stack); + free(state_stack); + free(location_stack); + free(string_stack); } } diff --git a/src/declarative/qml/parser/qdeclarativejsparser.cpp b/src/declarative/qml/parser/qdeclarativejsparser.cpp index 29ef64b32c..1639900338 100644 --- a/src/declarative/qml/parser/qdeclarativejsparser.cpp +++ b/src/declarative/qml/parser/qdeclarativejsparser.cpp @@ -70,10 +70,10 @@ void Parser::reallocateStack() else stack_size <<= 1; - sym_stack = reinterpret_cast<Value*> (qRealloc(sym_stack, stack_size * sizeof(Value))); - state_stack = reinterpret_cast<int*> (qRealloc(state_stack, stack_size * sizeof(int))); - location_stack = reinterpret_cast<AST::SourceLocation*> (qRealloc(location_stack, stack_size * sizeof(AST::SourceLocation))); - string_stack = reinterpret_cast<QStringRef*> (qRealloc(string_stack, stack_size * sizeof(QStringRef))); + sym_stack = reinterpret_cast<Value*> (realloc(sym_stack, stack_size * sizeof(Value))); + state_stack = reinterpret_cast<int*> (realloc(state_stack, stack_size * sizeof(int))); + location_stack = reinterpret_cast<AST::SourceLocation*> (realloc(location_stack, stack_size * sizeof(AST::SourceLocation))); + string_stack = reinterpret_cast<QStringRef*> (realloc(string_stack, stack_size * sizeof(QStringRef))); } Parser::Parser(Engine *engine): @@ -93,10 +93,10 @@ Parser::Parser(Engine *engine): Parser::~Parser() { if (stack_size) { - qFree(sym_stack); - qFree(state_stack); - qFree(location_stack); - qFree(string_stack); + free(sym_stack); + free(state_stack); + free(location_stack); + free(string_stack); } } diff --git a/src/declarative/qml/qdeclarativeboundsignal.cpp b/src/declarative/qml/qdeclarativeboundsignal.cpp index c7a874937c..51691ca6bd 100644 --- a/src/declarative/qml/qdeclarativeboundsignal.cpp +++ b/src/declarative/qml/qdeclarativeboundsignal.cpp @@ -266,7 +266,7 @@ QDeclarativeBoundSignalParameters::QDeclarativeBoundSignalParameters(const QMeta QDeclarativeBoundSignalParameters::~QDeclarativeBoundSignalParameters() { delete [] types; - qFree(myMetaObject); + free(myMetaObject); } void QDeclarativeBoundSignalParameters::setValues(void **v) diff --git a/src/declarative/qml/qdeclarativeopenmetaobject.cpp b/src/declarative/qml/qdeclarativeopenmetaobject.cpp index ad3013b467..6dbd254421 100644 --- a/src/declarative/qml/qdeclarativeopenmetaobject.cpp +++ b/src/declarative/qml/qdeclarativeopenmetaobject.cpp @@ -75,7 +75,7 @@ QDeclarativeOpenMetaObjectType::QDeclarativeOpenMetaObjectType(const QMetaObject QDeclarativeOpenMetaObjectType::~QDeclarativeOpenMetaObjectType() { if (d->mem) - qFree(d->mem); + free(d->mem); if (d->cache) d->cache->release(); delete d; @@ -102,7 +102,7 @@ int QDeclarativeOpenMetaObjectType::createProperty(const QByteArray &name) d->mob.addSignal("__" + QByteArray::number(id) + "()"); QMetaPropertyBuilder build = d->mob.addProperty(name, "QVariant", id); propertyCreated(id, build); - qFree(d->mem); + free(d->mem); d->mem = d->mob.toMetaObject(); d->names.insert(name, id); QSet<QDeclarativeOpenMetaObject*>::iterator it = d->referers.begin(); diff --git a/src/declarative/qml/qdeclarativepropertycache.cpp b/src/declarative/qml/qdeclarativepropertycache.cpp index 55096eafa0..c3f197d941 100644 --- a/src/declarative/qml/qdeclarativepropertycache.cpp +++ b/src/declarative/qml/qdeclarativepropertycache.cpp @@ -254,7 +254,7 @@ QDeclarativePropertyCache::~QDeclarativePropertyCache() QDeclarativePropertyCacheMethodArguments *args = argumentsCache; while (args) { QDeclarativePropertyCacheMethodArguments *next = args->next; - qFree(args); + free(args); args = next; } @@ -725,7 +725,7 @@ int *QDeclarativePropertyCache::methodParameterTypes(QObject *object, int index, QMetaMethod m = metaObject->method(index); QList<QByteArray> argTypeNames = m.parameterTypes(); - A *args = static_cast<A *>(qMalloc(sizeof(A) + (argTypeNames.count() + 1) * sizeof(int))); + A *args = static_cast<A *>(malloc(sizeof(A) + (argTypeNames.count() + 1) * sizeof(int))); args->arguments[0] = argTypeNames.count(); for (int ii = 0; ii < argTypeNames.count(); ++ii) { @@ -734,7 +734,7 @@ int *QDeclarativePropertyCache::methodParameterTypes(QObject *object, int index, type = EnumType(object->metaObject(), argTypeNames.at(ii)); if (type == QVariant::Invalid) { if (unknownTypeError) *unknownTypeError = argTypeNames.at(ii); - qFree(args); + free(args); return 0; } args->arguments[ii + 1] = type; |