diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-11-23 16:33:45 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2020-11-23 22:16:17 +0000 |
commit | c958c93ac5e06986604a9a381b196d3dd2b6b73a (patch) | |
tree | 14c2e5bff1a53b0602d6440c7e16cd909bf84aca /src/particles | |
parent | 944299e83f44063ab3483f171a9faf3c2721d8dd (diff) |
QQuickParticleAffector: Fix warnings about copying non-shared containers
Use range-based for, fixing:
'QtPrivate::warnIfContainerIsNotShared': Do not use foreach/Q_FOREACH with containers which are not implicitly shared. Prefer using a range-based for loop with these containers: `for (const auto &it : container)`, keeping in mind that range-based for doesn't copy the container as Q_FOREACH does
T=QVarLengthArray<QQuickParticleGroupData *,32> &
'QtPrivate::warnIfContainerIsNotShared': Do not use foreach/Q_FOREACH with containers which are not implicitly shared. Prefer using a range-based for loop with these containers: `for (const auto &it : container)`, keeping in mind that range-based for doesn't copy the container as Q_FOREACH does
T=QQuickParticleVarLengthArray<QQuickParticlePainter *,4> &
Change-Id: I88d7405abd89d2fa47549623997cbc02a9bd1145
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 938986fb464601ad3104ee86d03f2ef562e24315)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/particles')
-rw-r--r-- | src/particles/qquickparticleaffector.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/particles/qquickparticleaffector.cpp b/src/particles/qquickparticleaffector.cpp index 9aae0db280..aefaa2c399 100644 --- a/src/particles/qquickparticleaffector.cpp +++ b/src/particles/qquickparticleaffector.cpp @@ -209,9 +209,9 @@ void QQuickParticleAffector::affectSystem(qreal dt) updateOffsets();//### Needed if an ancestor is transformed. if (m_onceOff) dt = 1.0; - foreach (QQuickParticleGroupData* gd, m_system->groupData) { + for (QQuickParticleGroupData* gd : qAsConst(m_system->groupData)) { if (activeGroup(gd->index)) { - foreach (QQuickParticleData* d, gd->data) { + for (QQuickParticleData* d : qAsConst(gd->data)) { if (shouldAffect(d)) { bool affected = false; qreal myDt = dt; |