diff options
author | Albert Astals Cid <albert.astals.cid@kdab.com> | 2019-10-04 14:13:36 +0200 |
---|---|---|
committer | Albert Astals Cid <albert.astals.cid@kdab.com> | 2019-10-07 09:09:49 +0200 |
commit | ce94b847c87e2606c5f189d2ad3715c1d025b9cf (patch) | |
tree | 94ccb94300d87ddafb465ce82c6f60601ce0749b /src/particles | |
parent | 2b371a50cbc1f54284fcea3834834ca58fc28fd0 (diff) |
Small performance improvements suggested by clang-tidy
mostly add const &, a few std::move and in particular case, remove const
so the std::move being done over the variable actually has effect
Change-Id: Id611cd31bc012f219d7a17d4626b1c2a5fbddd66
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/particles')
-rw-r--r-- | src/particles/qquickcustomaffector.cpp | 2 | ||||
-rw-r--r-- | src/particles/qquickcustomaffector_p.h | 2 | ||||
-rw-r--r-- | src/particles/qquickmaskextruder.cpp | 4 | ||||
-rw-r--r-- | src/particles/qquickmaskextruder_p.h | 4 |
4 files changed, 6 insertions, 6 deletions
diff --git a/src/particles/qquickcustomaffector.cpp b/src/particles/qquickcustomaffector.cpp index cadd2992b1..5e2133dfaf 100644 --- a/src/particles/qquickcustomaffector.cpp +++ b/src/particles/qquickcustomaffector.cpp @@ -233,7 +233,7 @@ bool QQuickCustomAffector::affectParticle(QQuickParticleData *d, qreal dt) return changed; } -void QQuickCustomAffector::affectProperties(const QList<QQuickParticleData*> particles, qreal dt) +void QQuickCustomAffector::affectProperties(const QList<QQuickParticleData*> &particles, qreal dt) { foreach (QQuickParticleData* d, particles) if ( affectParticle(d, dt) ) diff --git a/src/particles/qquickcustomaffector_p.h b/src/particles/qquickcustomaffector_p.h index 10db70d71d..5b1ea55659 100644 --- a/src/particles/qquickcustomaffector_p.h +++ b/src/particles/qquickcustomaffector_p.h @@ -156,7 +156,7 @@ protected: bool affectParticle(QQuickParticleData *d, qreal dt) override; private: - void affectProperties(const QList<QQuickParticleData*> particles, qreal dt); + void affectProperties(const QList<QQuickParticleData*> &particles, qreal dt); QQuickDirection * m_position; QQuickDirection * m_velocity; QQuickDirection * m_acceleration; diff --git a/src/particles/qquickmaskextruder.cpp b/src/particles/qquickmaskextruder.cpp index 4c5d9e9d88..2ce3650743 100644 --- a/src/particles/qquickmaskextruder.cpp +++ b/src/particles/qquickmaskextruder.cpp @@ -68,14 +68,14 @@ QQuickMaskExtruder::QQuickMaskExtruder(QObject *parent) : { } -void QQuickMaskExtruder::setSource(QUrl arg) +void QQuickMaskExtruder::setSource(const QUrl &arg) { if (m_source != arg) { m_source = arg; m_lastHeight = -1;//Trigger reset m_lastWidth = -1; - emit sourceChanged(arg); + emit sourceChanged(m_source); startMaskLoading(); } } diff --git a/src/particles/qquickmaskextruder_p.h b/src/particles/qquickmaskextruder_p.h index 0fc0331db8..bbb61b0d28 100644 --- a/src/particles/qquickmaskextruder_p.h +++ b/src/particles/qquickmaskextruder_p.h @@ -73,10 +73,10 @@ public: Q_SIGNALS: - void sourceChanged(QUrl arg); + void sourceChanged(const QUrl &arg); public Q_SLOTS: - void setSource(QUrl arg); + void setSource(const QUrl &arg); private Q_SLOTS: void startMaskLoading(); |