Ensure that markDirty is called when needed

There were many cases where properties of nodes could change but since
the node was not marked dirty, the scene update was never rendered.

Change-Id: I7740a43d98521073056f85fe80d6c1ff213236a3
Reviewed-by: Andy Nichols <andy.nichols@digia.com>

1 files changed, 31 insertions, 2 deletions

diff --git a/src/plugins/scenegraph/softwarecontext/imagenode.cpp b/src/plugins/scenegraph/softwarecontext/imagenode.cpp
index 27583821ae..3146830172 100644
--- a/src/plugins/scenegraph/softwarecontext/imagenode.cpp
+++ b/src/plugins/scenegraph/softwarecontext/imagenode.cpp
@@ -303,22 +303,34 @@ ImageNode::ImageNode()
 
 void ImageNode::setTargetRect(const QRectF &rect)
 {
+    if (rect == m_targetRect)
+        return;
     m_targetRect = rect;
+    markDirty(DirtyGeometry);
 }
 
 void ImageNode::setInnerTargetRect(const QRectF &rect)
 {
+    if (rect == m_innerTargetRect)
+        return;
     m_innerTargetRect = rect;
+    markDirty(DirtyGeometry);
 }
 
 void ImageNode::setInnerSourceRect(const QRectF &rect)
 {
+    if (rect == m_innerSourceRect)
+        return;
     m_innerSourceRect = rect;
+    markDirty(DirtyGeometry);
 }
 
 void ImageNode::setSubSourceRect(const QRectF &rect)
 {
+    if (rect == m_subSourceRect)
+        return;
     m_subSourceRect = rect;
+    markDirty(DirtyGeometry);
 }
 
 void ImageNode::setTexture(QSGTexture *texture)
@@ -326,6 +338,7 @@ void ImageNode::setTexture(QSGTexture *texture)
     if (m_texture != texture) {
         m_texture = texture;
         m_cachedMirroredPixmapIsDirty = true;
+        markDirty(DirtyMaterial);
     }
 }
 
@@ -334,6 +347,7 @@ void ImageNode::setMirror(bool mirror)
     if (m_mirror != mirror) {
         m_mirror = mirror;
         m_cachedMirroredPixmapIsDirty = true;
+        markDirty(DirtyMaterial);
     }
 }
 
@@ -343,17 +357,32 @@ void ImageNode::setMipmapFiltering(QSGTexture::Filtering /*filtering*/)
 
 void ImageNode::setFiltering(QSGTexture::Filtering filtering)
 {
-    m_smooth = (filtering == QSGTexture::Nearest);
+    bool smooth = (filtering == QSGTexture::Nearest);
+    if (smooth == m_smooth)
+        return;
+
+    m_smooth = smooth;
+    markDirty(DirtyMaterial);
 }
 
 void ImageNode::setHorizontalWrapMode(QSGTexture::WrapMode wrapMode)
 {
-    m_tileHorizontal = (wrapMode == QSGTexture::Repeat);
+    bool tileHorizontal = (wrapMode == QSGTexture::Repeat);
+    if (tileHorizontal == m_tileHorizontal)
+        return;
+
+    m_tileHorizontal = tileHorizontal;
+    markDirty(DirtyMaterial);
 }
 
 void ImageNode::setVerticalWrapMode(QSGTexture::WrapMode wrapMode)
 {
+    bool tileVertical = (wrapMode == QSGTexture::Repeat);
+    if (tileVertical == m_tileVertical)
+        return;
+
     m_tileVertical = (wrapMode == QSGTexture::Repeat);
+    markDirty(DirtyMaterial);
 }
 
 void ImageNode::update()