Merge remote-tracking branch 'origin/dev' into wip/cmake

 Conflicts:
        dependencies.yaml

Change-Id: Ie3e9dc62031a85e5e81cbdf04694b95159d49fca

5 files changed, 18 insertions, 13 deletions

diff --git a/src/plugins/qmltooling/qmldbg_debugger/qqmlenginedebugservice.cpp b/src/plugins/qmltooling/qmldbg_debugger/qqmlenginedebugservice.cpp
index 029004ffd1..a3d19841cf 100644
--- a/src/plugins/qmltooling/qmldbg_debugger/qqmlenginedebugservice.cpp
+++ b/src/plugins/qmltooling/qmldbg_debugger/qqmlenginedebugservice.cpp
@@ -96,7 +96,7 @@ static bool isSaveable(const QVariant &value)
 {
     NullDevice nullDevice;
     QDataStream fakeStream(&nullDevice);
-    return QMetaType::save(fakeStream, static_cast<int>(value.type()), value.constData());
+    return QMetaType::save(fakeStream, static_cast<int>(value.userType()), value.constData());
 }
 
 QQmlEngineDebugServiceImpl::QQmlEngineDebugServiceImpl(QObject *parent) :
@@ -217,7 +217,7 @@ QVariant QQmlEngineDebugServiceImpl::valueContents(QVariant value) const
     //QObject * is not streamable.
     //Convert all such instances to a String value
 
-    if (value.type() == QVariant::List) {
+    if (value.userType() == QMetaType::QVariantList) {
         QVariantList contents;
         QVariantList list = value.toList();
         int count = list.size();
@@ -227,7 +227,7 @@ QVariant QQmlEngineDebugServiceImpl::valueContents(QVariant value) const
         return contents;
     }
 
-    if (value.type() == QVariant::Map) {
+    if (value.userType() == QMetaType::QVariantMap) {
         QVariantMap contents;
         const auto map = value.toMap();
         for (auto i = map.cbegin(), end = map.cend(); i != end; ++i)
diff --git a/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.cpp b/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.cpp
index d4acd24da5..52e197b1ed 100644
--- a/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.cpp
+++ b/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.cpp
@@ -51,7 +51,7 @@ static QVector<QQmlPreviewPosition::ScreenData> initScreensData()
     QVector<QQmlPreviewPosition::ScreenData> screensData;
 
     for (QScreen *screen : QGuiApplication::screens()) {
-        QQmlPreviewPosition::ScreenData sd{screen->name(), screen->size()};
+        QQmlPreviewPosition::ScreenData sd{screen->name(), screen->geometry()};
         screensData.append(sd);
     }
     return screensData;
@@ -69,20 +69,20 @@ static QScreen *findScreen(const QString &nameOfScreen)
 static QDataStream &operator<<(QDataStream &out, const QQmlPreviewPosition::ScreenData &screenData)
 {
     out << screenData.name;
-    out << screenData.size;
+    out << screenData.rect;
     return out;
 }
 
 static QDataStream &operator>>(QDataStream &in, QQmlPreviewPosition::ScreenData &screenData)
 {
     in >> screenData.name;
-    in >> screenData.size;
+    in >> screenData.rect;
     return in;
 }
 
 bool QQmlPreviewPosition::ScreenData::operator==(const QQmlPreviewPosition::ScreenData &other) const
 {
-    return other.size == size && other.name == name;
+    return other.rect == rect && other.name == name;
 }
 
 QQmlPreviewPosition::QQmlPreviewPosition()
@@ -211,8 +211,13 @@ void QQmlPreviewPosition::setPosition(const QQmlPreviewPosition::Position &posit
         return;
     if (QScreen *screen = findScreen(position.screenName)) {
         window->setScreen(screen);
-        window->setFramePosition(QHighDpiScaling::mapPositionFromNative(position.nativePosition,
-                                                                        screen->handle()));
+        const auto point = QHighDpiScaling::mapPositionFromNative(position.nativePosition,
+                                                                  screen->handle());
+        const QRect geometry(point, window->size());
+        if (screen->virtualGeometry().contains(geometry))
+            window->setFramePosition(point);
+        else
+            qWarning("preview position is out of screen");
     }
 }
 
diff --git a/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.h b/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.h
index f403917f8c..9d84170948 100644
--- a/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.h
+++ b/src/plugins/qmltooling/qmldbg_preview/qqmlpreviewposition.h
@@ -56,7 +56,7 @@
 #include <QtCore/qurl.h>
 #include <QtCore/qtimer.h>
 #include <QtCore/qsettings.h>
-#include <QtCore/qsize.h>
+#include <QtCore/qrect.h>
 #include <QtCore/qdatastream.h>
 
 QT_BEGIN_NAMESPACE
@@ -70,7 +70,7 @@ public:
     public:
         bool operator==(const QQmlPreviewPosition::ScreenData &other) const;
         QString name;
-        QSize size;
+        QRect rect;
     };
     class Position {
     public:
diff --git a/src/plugins/qmltooling/qmldbg_profiler/qqmlprofileradapter.cpp b/src/plugins/qmltooling/qmldbg_profiler/qqmlprofileradapter.cpp
index a688e98b3f..4702bc3c33 100644
--- a/src/plugins/qmltooling/qmldbg_profiler/qqmlprofileradapter.cpp
+++ b/src/plugins/qmltooling/qmldbg_profiler/qqmlprofileradapter.cpp
@@ -153,7 +153,7 @@ void QQmlProfilerAdapter::receiveData(const QVector<QQmlProfilerData> &new_data,
     if (locations.isEmpty())
         locations = new_locations;
     else
-        locations.unite(new_locations);
+        locations.insert(new_locations);
 
     service->dataReady(this);
 }
diff --git a/src/plugins/qmltooling/qmldbg_profiler/qv4profileradapter.cpp b/src/plugins/qmltooling/qmldbg_profiler/qv4profileradapter.cpp
index 12c36f3dd6..fb2a28ea01 100644
--- a/src/plugins/qmltooling/qmldbg_profiler/qv4profileradapter.cpp
+++ b/src/plugins/qmltooling/qmldbg_profiler/qv4profileradapter.cpp
@@ -168,7 +168,7 @@ void QV4ProfilerAdapter::receiveData(
     if (m_functionLocations.isEmpty())
         m_functionLocations = locations;
     else
-        m_functionLocations.unite(locations);
+        m_functionLocations.insert(locations);
 
     if (m_functionCallData.isEmpty())
         m_functionCallData = functionCallData;