Clean up object literal handling with integral indices

* Object literals with array indices are now created with one
  run-time call, instead of an initial one for non-integral keys
  followed by sub-sequent define_builtin_property calls.

* Cleaned up propert name retrieval. Instead of using a visitor,
  it's easier to define a virtual method on the PropertyName type.  The visitor
  doesn't buy us much as it's not possible to recurse within property names, and
  this way we can use it also from the function scanner to correctly determine
  the number of arguments needed for object literal initalizations.

* Similarly the duplicated/common name member for all property assignments
  has been moved into PropertyName, for convenient access without AST casts.

* Removed now unused builtin_define_property/settergetter functions from IR,
  run-time and moth.

Change-Id: I90d54c81ea5f3f500f4f4a9c14f7caf5135e7f9f
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

1 files changed, 0 insertions, 6 deletions

diff --git a/src/qml/compiler/qv4codegen_p.h b/src/qml/compiler/qv4codegen_p.h
index 37055171b1..9c43dc17fe 100644
--- a/src/qml/compiler/qv4codegen_p.h
+++ b/src/qml/compiler/qv4codegen_p.h
@@ -315,7 +315,6 @@ protected:
     void statement(AST::ExpressionNode *ast);
     void condition(AST::ExpressionNode *ast, QV4::IR::BasicBlock *iftrue, QV4::IR::BasicBlock *iffalse);
     Result expression(AST::ExpressionNode *ast);
-    QString propertyName(AST::PropertyName *ast);
     Result sourceElement(AST::SourceElement *ast);
     UiMember uiObjectMember(AST::UiObjectMember *ast);
 
@@ -397,11 +396,6 @@ protected:
     virtual bool visit(AST::VoidExpression *ast);
     virtual bool visit(AST::FunctionDeclaration *ast);
 
-    // property names
-    virtual bool visit(AST::IdentifierPropertyName *ast);
-    virtual bool visit(AST::NumericLiteralPropertyName *ast);
-    virtual bool visit(AST::StringLiteralPropertyName *ast);
-
     // source elements
     virtual bool visit(AST::FunctionSourceElement *ast);
     virtual bool visit(AST::StatementSourceElement *ast);