diff options
| author | Simon Hausmann <simon.hausmann@digia.com> | 2013-11-02 20:35:33 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-11-12 18:20:30 +0100 |
| commit | 7a092000169a8e9d537f3d341ef48277397f997d (patch) | |
| tree | f29f189d57e4923dff2decfd073b8e04f4a211a8 /src/qml/compiler/qv4instr_moth_p.h | |
| parent | 7c6d2d78fe0997dfebba5569f097bdacbba5a861 (diff) | |
Fix property dependency generation for accelerated QML QObject properties
The previous approach of collecting the dependencies through an IR visitor
doesn't work, because it relies on a fixed structure - for example MEMBER(NAME,
prop) - which we can't guarantee (it's usually MEMBER(TEMP, prop)). But it
turns out that we can only pre-calculate dependencies for context, scope or id
properties, so we can do that right away in the QML specific JS codegen, store
that information in the IR function and use it from there in the data structure
generator as well as in the isel as a parameter to getQObjectProperty to tell
the run-time whether capture is required or not.
Change-Id: I33711c3420d6534c653c2a6a4284f0fc12e941cf
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Diffstat (limited to 'src/qml/compiler/qv4instr_moth_p.h')
| -rw-r--r-- | src/qml/compiler/qv4instr_moth_p.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/qml/compiler/qv4instr_moth_p.h b/src/qml/compiler/qv4instr_moth_p.h index 9aaab2f105..9baf7f89ca 100644 --- a/src/qml/compiler/qv4instr_moth_p.h +++ b/src/qml/compiler/qv4instr_moth_p.h @@ -286,6 +286,7 @@ union Instr int propertyIndex; Param base; Param result; + bool captureRequired; }; struct instr_storeProperty { MOTH_INSTR_HEADER |