diff options
| author | Lars Knoll <lars.knoll@qt.io> | 2018-08-29 14:25:09 +0200 |
|---|---|---|
| committer | Lars Knoll <lars.knoll@qt.io> | 2018-08-29 18:10:52 +0000 |
| commit | b6018a8167b23988542100312b4f2cd126c41700 (patch) | |
| tree | 2e55d759b2996f96c1fae84d2abc42ff83030f8c /src/qml/compiler | |
| parent | 123f01df338972e2253ae2ab993027755695ceea (diff) | |
Initialize this to empty for derived constructors
As per spec, this should be uninitialized in derived
constructors, and the base constructor needs to get
called exactly once.
Change-Id: If31804e58d7ba62efde8fbf6cd852674f8da4495
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/qml/compiler')
| -rw-r--r-- | src/qml/compiler/qv4codegen_p.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/qml/compiler/qv4codegen_p.h b/src/qml/compiler/qv4codegen_p.h index 1fc3c2180b..761b353066 100644 --- a/src/qml/compiler/qv4codegen_p.h +++ b/src/qml/compiler/qv4codegen_p.h @@ -338,6 +338,9 @@ public: static Reference fromThis(Codegen *cg) { Reference r = fromStackSlot(cg, CallData::This); r.isReadonly = true; + // ### Optimize this. Functions that are not derived constructors or arrow functions can't have an + // empty this object + r.requiresTDZCheck = true; return r; } |