Make name and version of QQmlDebugService const

They aren't supposed to change after construction.

Change-Id: I4aee0c04f5bb77b0e75c016ecbc72ea34639d587
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>

1 files changed, 4 insertions, 13 deletions

diff --git a/src/qml/debugger/qqmldebugservice.cpp b/src/qml/debugger/qqmldebugservice.cpp
index a171c26ea7..dda7fbe435 100644
--- a/src/qml/debugger/qqmldebugservice.cpp
+++ b/src/qml/debugger/qqmldebugservice.cpp
@@ -43,29 +43,20 @@
 
 QT_BEGIN_NAMESPACE
 
-QQmlDebugServicePrivate::QQmlDebugServicePrivate()
+QQmlDebugServicePrivate::QQmlDebugServicePrivate(const QString &name, float version) :
+    name(name), version(version), state(QQmlDebugService::NotConnected)
 {
 }
 
 QQmlDebugService::QQmlDebugService(const QString &name, float version, QObject *parent)
-    : QObject(*(new QQmlDebugServicePrivate), parent)
+    : QObject(*(new QQmlDebugServicePrivate(name, version)), parent)
 {
     QQmlDebugServer::instance(); // create it when it isn't there yet.
-
-    Q_D(QQmlDebugService);
-    d->name = name;
-    d->version = version;
-    d->state = QQmlDebugService::NotConnected;
 }
 
-QQmlDebugService::QQmlDebugService(QQmlDebugServicePrivate &dd,
-                                                   const QString &name, float version, QObject *parent)
+QQmlDebugService::QQmlDebugService(QQmlDebugServicePrivate &dd, QObject *parent)
     : QObject(dd, parent)
 {
-    Q_D(QQmlDebugService);
-    d->name = name;
-    d->version = version;
-    d->state = QQmlDebugService::NotConnected;
 }
 
 /**