aboutsummaryrefslogtreecommitdiffstats
path: root/src/qml/debugger
diff options
context:
space:
mode:
authorUlf Hermann <ulf.hermann@theqtcompany.com>2015-07-14 12:38:06 +0200
committerUlf Hermann <ulf.hermann@theqtcompany.com>2015-07-29 14:36:03 +0000
commitad633f595d3f79be558b05744a01de6355a8d5ef (patch)
treeeb940972bb93a379bf3a3a06da0685ef97cdd1d4 /src/qml/debugger
parent6d019b08cdd7f995b62956d29594b498fe3f61e4 (diff)
Don't exposes QQmlDebugServer's list of services.
The only thing we ever want to do is look up a service by name. Change-Id: I45007d3c742201ccc0871379a91b37381f6d1760 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
Diffstat (limited to 'src/qml/debugger')
-rw-r--r--src/qml/debugger/qqmldebugserver.cpp11
-rw-r--r--src/qml/debugger/qqmldebugserver_p.h3
-rw-r--r--src/qml/debugger/qqmldebugservice.cpp2
3 files changed, 4 insertions, 12 deletions
diff --git a/src/qml/debugger/qqmldebugserver.cpp b/src/qml/debugger/qqmldebugserver.cpp
index 7d0ed00757..7cd93824b8 100644
--- a/src/qml/debugger/qqmldebugserver.cpp
+++ b/src/qml/debugger/qqmldebugserver.cpp
@@ -644,18 +644,11 @@ void QQmlDebugServerPrivate::_q_removeThread()
q_func()->moveToThread(parentThread);
}
-QList<QQmlDebugService*> QQmlDebugServer::services() const
+QQmlDebugService *QQmlDebugServer::service(const QString &name) const
{
Q_D(const QQmlDebugServer);
QReadLocker lock(&d->pluginsLock);
- return d->plugins.values();
-}
-
-QStringList QQmlDebugServer::serviceNames() const
-{
- Q_D(const QQmlDebugServer);
- QReadLocker lock(&d->pluginsLock);
- return d->plugins.keys();
+ return d->plugins.value(name);
}
void QQmlDebugServer::addEngine(QQmlEngine *engine)
diff --git a/src/qml/debugger/qqmldebugserver_p.h b/src/qml/debugger/qqmldebugserver_p.h
index fdac9e1abf..617f589d24 100644
--- a/src/qml/debugger/qqmldebugserver_p.h
+++ b/src/qml/debugger/qqmldebugserver_p.h
@@ -64,8 +64,7 @@ public:
bool blockingMode() const;
- QList<QQmlDebugService*> services() const;
- QStringList serviceNames() const;
+ QQmlDebugService *service(const QString &name) const;
void addEngine(QQmlEngine *engine);
void removeEngine(QQmlEngine *engine);
diff --git a/src/qml/debugger/qqmldebugservice.cpp b/src/qml/debugger/qqmldebugservice.cpp
index 59ff1db699..0b5ddddb15 100644
--- a/src/qml/debugger/qqmldebugservice.cpp
+++ b/src/qml/debugger/qqmldebugservice.cpp
@@ -71,7 +71,7 @@ QQmlDebugService::State QQmlDebugService::registerService()
if (!server)
return NotConnected;
- if (server->serviceNames().contains(d->name)) {
+ if (server->service(d->name)) {
qWarning() << "QQmlDebugService: Conflicting plugin name" << d->name;
} else {
server->addService(this);