diff options
| author | Simon Hausmann <simon.hausmann@digia.com> | 2014-04-09 13:32:39 +0200 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-04-09 16:49:05 +0200 |
| commit | 7b3eb5373a0d3611c5a83379c5eb59505cc5c074 (patch) | |
| tree | b2f9f5e7beb86b065ef206f5d45025975ef49905 /src/qml/jsruntime/qv4argumentsobject.cpp | |
| parent | 60730cbb5e5475b5db6a15641211aa6958a93197 (diff) | |
Fix unreliable behavior of array methods on qml list properties
Array methods such as forEach rely on the hasProperty boolean of getIndexed to
be set appropriately. Some getIndexed implementation - such as the
QQmlListProperty one - didn't initialize it correctly and therefore the
behavior was undefined.
Task-number: QTBUG-38088
Change-Id: I34bc3136d8cc2bc280397d0c4d5051e7d72269e8
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Diffstat (limited to 'src/qml/jsruntime/qv4argumentsobject.cpp')
| -rw-r--r-- | src/qml/jsruntime/qv4argumentsobject.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/qml/jsruntime/qv4argumentsobject.cpp b/src/qml/jsruntime/qv4argumentsobject.cpp index 1c210b53b6..987b228209 100644 --- a/src/qml/jsruntime/qv4argumentsobject.cpp +++ b/src/qml/jsruntime/qv4argumentsobject.cpp @@ -160,6 +160,8 @@ ReturnedValue ArgumentsObject::getIndexed(Managed *m, uint index, bool *hasPrope *hasProperty = true; return args->context->callData->args[index].asReturnedValue(); } + if (hasProperty) + *hasProperty = false; return Encode::undefined(); } |