aboutsummaryrefslogtreecommitdiffstats
path: root/src/qml/jsruntime/qv4arraydata_p.h
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2017-08-28 08:59:03 +0200
committerLars Knoll <lars.knoll@qt.io>2017-08-28 11:48:59 +0000
commit7d6ebbf355fb3e8a0729d0805fe6039eebe5dfdf (patch)
treeb7df492abe39fec2f1c714b7c5bdfce612b9cb7e /src/qml/jsruntime/qv4arraydata_p.h
parentb56f7d6f79b0de73c405b1503bfeb71ef5caf58f (diff)
Fix off-by-one error when mapping array index to offset in the array
Amends acaa28e916b0d89e3c243cc3f8a46fcf74d8be63 Change-Id: I1429b5d4b2102f9b0a6baea7c6872aecd739be44 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/qml/jsruntime/qv4arraydata_p.h')
-rw-r--r--src/qml/jsruntime/qv4arraydata_p.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qml/jsruntime/qv4arraydata_p.h b/src/qml/jsruntime/qv4arraydata_p.h
index 5028778877..6e41c756a8 100644
--- a/src/qml/jsruntime/qv4arraydata_p.h
+++ b/src/qml/jsruntime/qv4arraydata_p.h
@@ -144,7 +144,7 @@ DECLARE_HEAP_OBJECT(ArrayData, Base) {
V4_ASSERT_IS_TRIVIAL(ArrayData)
struct SimpleArrayData : public ArrayData {
- uint mappedIndex(uint index) const { index += offset; if (index > values.alloc) index -= values.alloc; return index; }
+ uint mappedIndex(uint index) const { index += offset; if (index >= values.alloc) index -= values.alloc; return index; }
const Value &data(uint index) const { return values[mappedIndex(index)]; }
void setData(EngineBase *e, uint index, Value newVal) {
values.set(e, mappedIndex(index), newVal);