aboutsummaryrefslogtreecommitdiffstats
path: root/src/qml/jsruntime/qv4engine.cpp
diff options
context:
space:
mode:
authorSimon Hausmann <simon.hausmann@qt.io>2017-10-02 16:54:27 +0200
committerSimon Hausmann <simon.hausmann@qt.io>2017-10-04 10:17:47 +0000
commit837da5953ff325a5bc5171a0c1f9f7aecd4834e9 (patch)
tree585008587dfac9df26d379262278537b25997fca /src/qml/jsruntime/qv4engine.cpp
parent265b3bea18c1ac13da413931024f64f49a2da7fc (diff)
Fix Number.isNaN sometimes returning false for NaN
We use Encode(std::isnan(v)) and while std::isnan() is documented to have bool as a return type, there is the case where cmath pulls ::isnan into std with a using declaration when ::isnan() will sometimes return an int. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69450 This appears to be the only case where we use the overloaded Encode() constructor in conjunction with a direct std::isXXX call. [ChangeLog][QtQml] Fix Number.isNaN() returning incorrect values with some glibc versions. Task-number: QTBUG-63464 Change-Id: Iaaba3735f7400eac0950aad8f3ac47befaf9dab9 Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io> Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'src/qml/jsruntime/qv4engine.cpp')
0 files changed, 0 insertions, 0 deletions