Move saveToDisk into SaveableUnitPointer

This way we can keep the flag mutilation closely local to the place
where we write the data. Also, SaveableUnitPointer doesn't need a full
CompilationUnit this way.

Change-Id: I01872e4c406cb2ccbaa1fa35325cc063b1e8a7df
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
 

1 files changed, 5 insertions, 1 deletions

diff --git a/src/qml/jsruntime/qv4executablecompilationunit.cpp b/src/qml/jsruntime/qv4executablecompilationunit.cpp
index 7867dff769..1e725cbef7 100644
--- a/src/qml/jsruntime/qv4executablecompilationunit.cpp
+++ b/src/qml/jsruntime/qv4executablecompilationunit.cpp
@@ -687,7 +687,11 @@ bool ExecutableCompilationUnit::saveToDisk(const QUrl &unitUrl, QString *errorSt
         return false;
     }
 
-    return CompilationUnit::saveToDisk(localCacheFilePath(unitUrl), errorString);
+    return CompiledData::SaveableUnitPointer(unitData()).saveToDisk<char>(
+            [this, &unitUrl, errorString](const char *data, quint32 size) {
+        return CompiledData::SaveableUnitPointer::writeDataToFile(localCacheFilePath(unitUrl), data,
+                                                                  size, errorString);
+    });
 }
 
 /*!