path: root/src/qml/jsruntime/qv4object_p.h
diff options
authorLars Knoll <>2018-04-04 12:09:12 +0200
committerLars Knoll <>2018-05-02 14:17:33 +0000
commit0496475831972387fe74733fec6de68c4fcb2c45 (patch)
tree21b75afbe7b0c1f7259e6e145170cc349f680c2c /src/qml/jsruntime/qv4object_p.h
parentd5f5f86824437bff8946c83d4369536a6de6f0e7 (diff)
The length of array like objects can in some cases be 2^53 -1 in ES7
Add a Value::getLength(), that converts a Value to a length bound between 0 and 2^53-1 as per ES7 spec. Use the extended range in Array.prototype.splice and map to fix hanging test cases. Change-Id: If9280d501423cfc10a60abd4e8aa30521d2a7bca Reviewed-by: Simon Hausmann <>
Diffstat (limited to 'src/qml/jsruntime/qv4object_p.h')
1 files changed, 4 insertions, 4 deletions
diff --git a/src/qml/jsruntime/qv4object_p.h b/src/qml/jsruntime/qv4object_p.h
index 79ffef47ba..7b1046d6ee 100644
--- a/src/qml/jsruntime/qv4object_p.h
+++ b/src/qml/jsruntime/qv4object_p.h
@@ -174,7 +174,7 @@ struct ObjectVTable
PropertyAttributes (*queryIndexed)(const Managed *, uint index);
bool (*deleteProperty)(Managed *m, String *name);
bool (*deleteIndexedProperty)(Managed *m, uint index);
- uint (*getLength)(const Managed *m);
+ qint64 (*getLength)(const Managed *m);
void (*advanceIterator)(Managed *m, ObjectIterator *it, Value *name, uint *index, Property *p, PropertyAttributes *attributes);
ReturnedValue (*instanceOf)(const Object *typeObject, const Value &var);
@@ -406,7 +406,7 @@ public:
{ return vtable()->deleteIndexedProperty(this, index); }
void advanceIterator(ObjectIterator *it, Value *name, uint *index, Property *p, PropertyAttributes *attributes)
{ vtable()->advanceIterator(this, it, name, index, p, attributes); }
- uint getLength() const { return vtable()->getLength(this); }
+ quint64 getLength() const { return vtable()->getLength(this); }
ReturnedValue instanceOf(const Value &var) const
{ return vtable()->instanceOf(this, var); }
@@ -422,7 +422,7 @@ protected:
static bool deleteProperty(Managed *m, String *name);
static bool deleteIndexedProperty(Managed *m, uint index);
static void advanceIterator(Managed *m, ObjectIterator *it, Value *name, uint *index, Property *p, PropertyAttributes *attributes);
- static uint getLength(const Managed *m);
+ static qint64 getLength(const Managed *m);
static ReturnedValue instanceOf(const Object *typeObject, const Value &var);
@@ -504,7 +504,7 @@ struct ArrayObject: Object {
void init(ExecutionEngine *engine);
using Object::getLength;
- static uint getLength(const Managed *m);
+ static qint64 getLength(const Managed *m);
QStringList toQStringList() const;