Always create a valid CallData object for interpreter calls

This will allow removing a few more special cases and to simplify
the code further.

Change-Id: I3a958e9f68e3c103ea4f2ee6825f893e5931b11d
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>

1 files changed, 11 insertions, 28 deletions

diff --git a/src/qml/jsruntime/qv4profiling_p.h b/src/qml/jsruntime/qv4profiling_p.h
index be38690a49..9b71342467 100644
--- a/src/qml/jsruntime/qv4profiling_p.h
+++ b/src/qml/jsruntime/qv4profiling_p.h
@@ -59,9 +59,6 @@
 
 #ifdef QT_NO_QML_DEBUGGER
 
-#define Q_V4_PROFILE_ALLOC(engine, size, type) (!engine)
-#define Q_V4_PROFILE_DEALLOC(engine, size, type) (!engine)
-#define Q_V4_PROFILE(engine, context, function, jsFunction) (function->code(context, function, jsFunction))
 
 QT_BEGIN_NAMESPACE
 
@@ -75,22 +72,6 @@ QT_END_NAMESPACE
 
 #else
 
-#define Q_V4_PROFILE_ALLOC(engine, size, type)\
-    (engine->profiler() &&\
-            (engine->profiler()->featuresEnabled & (1 << Profiling::FeatureMemoryAllocation)) ?\
-        engine->profiler()->trackAlloc(size, type) : false)
-
-#define Q_V4_PROFILE_DEALLOC(engine, size, type) \
-    (engine->profiler() &&\
-            (engine->profiler()->featuresEnabled & (1 << Profiling::FeatureMemoryAllocation)) ?\
-        engine->profiler()->trackDealloc(size, type) : false)
-
-#define Q_V4_PROFILE(engine, context, function, jsFunction)\
-    (Q_UNLIKELY(engine->profiler()) &&\
-            (engine->profiler()->featuresEnabled & (1 << Profiling::FeatureFunctionCall)) ?\
-        Profiling::FunctionCallProfiler::profileCall(engine->profiler(), context, function, jsFunction) :\
-        function->code(context, function, jsFunction))
-
 QT_BEGIN_NAMESPACE
 
 namespace QV4 {
@@ -270,19 +251,21 @@ public:
 
     // It's enough to ref() the function in the destructor as it will probably not disappear while
     // it's executing ...
-    FunctionCallProfiler(Profiler *profiler, Function *function) :
-        profiler(profiler), function(function), startTime(profiler->m_timer.nsecsElapsed())
-    {}
-
-    ~FunctionCallProfiler()
+    FunctionCallProfiler(ExecutionEngine *engine, Function *f)
+        : profiler(0)
     {
-        profiler->m_data.append(FunctionCall(function, startTime, profiler->m_timer.nsecsElapsed()));
+        Profiler *p = engine->profiler();
+        if (Q_UNLIKELY(p) && (p->featuresEnabled & (1 << Profiling::FeatureFunctionCall))) {
+            profiler = p;
+            function = f;
+            startTime = profiler->m_timer.nsecsElapsed();
+        }
     }
 
-    static ReturnedValue profileCall(Profiler *profiler, Heap::ExecutionContext *context, Function *function, const FunctionObject *jsFunction)
+    ~FunctionCallProfiler()
     {
-        FunctionCallProfiler callProfiler(profiler, function);
-        return function->code(context, function, jsFunction);
+        if (profiler)
+            profiler->m_data.append(FunctionCall(function, startTime, profiler->m_timer.nsecsElapsed()));
     }
 
     Profiler *profiler;