diff options
author | Lars Knoll <lars.knoll@digia.com> | 2013-09-30 22:41:12 +0200 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-10-02 16:07:33 +0200 |
commit | d49cc03df130353665edd89112fd4e1f3cdab9b6 (patch) | |
tree | cc55f49b6a2bc6b3b94e47fbdebe9d87f4857a07 /src/qml/jsruntime/qv4regexpobject.cpp | |
parent | ac8afca822031f3039dce31525a6ab48c741e73b (diff) |
Use SafeValue instead of Value in ScopedValue methods
Change-Id: Ie463efe600d498ce77d4b9e8b48abcfd61c1ab78
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Diffstat (limited to 'src/qml/jsruntime/qv4regexpobject.cpp')
-rw-r--r-- | src/qml/jsruntime/qv4regexpobject.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/qml/jsruntime/qv4regexpobject.cpp b/src/qml/jsruntime/qv4regexpobject.cpp index 899938faae..9c7fe94759 100644 --- a/src/qml/jsruntime/qv4regexpobject.cpp +++ b/src/qml/jsruntime/qv4regexpobject.cpp @@ -243,7 +243,8 @@ ReturnedValue RegExpCtor::construct(Managed *m, CallData *callData) ScopedValue r(scope, callData->argument(0)); ScopedValue f(scope, callData->argument(1)); - if (RegExpObject *re = r->as<RegExpObject>()) { + Scoped<RegExpObject> re(scope, r); + if (re) { if (!f->isUndefined()) ctx->throwTypeError(); @@ -273,11 +274,11 @@ ReturnedValue RegExpCtor::construct(Managed *m, CallData *callData) } } - RegExp* re = RegExp::create(ctx->engine, pattern, ignoreCase, multiLine); - if (!re->isValid()) + RegExp *regexp = RegExp::create(ctx->engine, pattern, ignoreCase, multiLine); + if (!regexp->isValid()) ctx->throwSyntaxError(0); - return Encode(ctx->engine->newRegExpObject(re, global)); + return Encode(ctx->engine->newRegExpObject(regexp, global)); } ReturnedValue RegExpCtor::call(Managed *that, CallData *callData) @@ -341,7 +342,7 @@ ReturnedValue RegExpPrototype::method_exec(SimpleCallContext *ctx) array->setArrayLengthUnchecked(len); array->memberData[Index_ArrayIndex].value = Primitive::fromInt32(result); - array->memberData[Index_ArrayInput].value = arg; + array->memberData[Index_ArrayInput].value = arg.asReturnedValue(); if (r->global) r->lastIndexProperty(ctx)->value = Primitive::fromInt32(matchOffsets[1]); |