Minor cleanup

Narrow the scope of the match offsets counter, as suggested by the clang static
code analyzer. In the second case we just wrote to the variable but never read
it.

Change-Id: I9e5e22bd27f892e76eccfea8b02f25795b689c36
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/src/qml/jsruntime/qv4stringobject.cpp b/src/qml/jsruntime/qv4stringobject.cpp
index 46cef39ea5..402ab420fc 100644
--- a/src/qml/jsruntime/qv4stringobject.cpp
+++ b/src/qml/jsruntime/qv4stringobject.cpp
@@ -482,12 +482,12 @@ ReturnedValue StringPrototype::method_replace(CallContext *ctx)
     uint allocatedMatchOffsets = 64;
     uint _matchOffsets[64];
     uint *matchOffsets = _matchOffsets;
-    uint nMatchOffsets = 0;
 
     ScopedValue searchValue(scope, ctx->argument(0));
     Scoped<RegExpObject> regExp(scope, searchValue);
     if (regExp) {
         uint offset = 0;
+        uint nMatchOffsets = 0;
 
         // We extract the pointer here to work around a compiler bug on Android.
         Scoped<RegExp> re(scope, regExp->value());
@@ -520,7 +520,6 @@ ReturnedValue StringPrototype::method_replace(CallContext *ctx)
         int idx = string.indexOf(searchString);
         if (idx != -1) {
             numStringMatches = 1;
-            nMatchOffsets = 2;
             matchOffsets[0] = idx;
             matchOffsets[1] = idx + searchString.length();
         }