QmlJS: Do not use realloc for QStringRef

It has a non-default copy ctor.

This is in fact a false positive, since the copy ctor just explicitly
copies all the members...

Detected by GCC8.

qqmljsparser.cpp: In member function ‘void QmlJS::Parser::reallocateStack()’:
qqmljsparser.cpp:68:104: warning: ‘void* realloc(void*, size_t)’ moving an object of non-trivially copyable type ‘class QStringRef’; use ‘new’ and ‘delete’ instead [-Wclass-memaccess]

Change-Id: Ica88740006374d83f25e20a3af58de524b552ce9
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>

1 files changed, 2 insertions, 3 deletions

diff --git a/src/qml/parser/qqmljs.g b/src/qml/parser/qqmljs.g
index 20c9b5720a..75bdb7b23f 100644
--- a/src/qml/parser/qqmljs.g
+++ b/src/qml/parser/qqmljs.g
@@ -406,7 +406,7 @@ protected:
     Value *sym_stack = nullptr;
     int *state_stack = nullptr;
     AST::SourceLocation *location_stack = nullptr;
-    QStringRef *string_stack = nullptr;
+    QVector<QStringRef> string_stack;
 
     AST::Node *program = nullptr;
 
@@ -483,7 +483,7 @@ void Parser::reallocateStack()
     sym_stack = reinterpret_cast<Value*> (realloc(sym_stack, stack_size * sizeof(Value)));
     state_stack = reinterpret_cast<int*> (realloc(state_stack, stack_size * sizeof(int)));
     location_stack = reinterpret_cast<AST::SourceLocation*> (realloc(location_stack, stack_size * sizeof(AST::SourceLocation)));
-    string_stack = reinterpret_cast<QStringRef*> (realloc(string_stack, stack_size * sizeof(QStringRef)));
+    string_stack.resize(stack_size);
 }
 
 Parser::Parser(Engine *engine):
@@ -498,7 +498,6 @@ Parser::~Parser()
         free(sym_stack);
         free(state_stack);
         free(location_stack);
-        free(string_stack);
     }
 }