diff options
| author | Lars Knoll <lars.knoll@theqtcompany.com> | 2015-01-15 11:36:57 +0100 |
|---|---|---|
| committer | Lars Knoll <lars.knoll@digia.com> | 2015-01-23 08:07:32 +0100 |
| commit | 002a5d4303b3b182ae4abc4a752c49787c1c2821 (patch) | |
| tree | 69c7666ed1061c7acacee1d76597c06405459c80 /src/qml/qml/qqmlbinding.cpp | |
| parent | fddc75e862032163af36d2282051758647b62d15 (diff) | |
Get rid of most uses of ValueRef
Instead pass a const Value & into the functions
With our new inheritance structure, we can get rid of ValueRef
and instead simply pass a pointer to a Value again. Pointers to
Values are safe to use again now, as they are now guaranteed to
be in a place where the GC knows about them.
Change-Id: I44c606fde764db3993b8128fd6fb781d3a298e53
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Diffstat (limited to 'src/qml/qml/qqmlbinding.cpp')
| -rw-r--r-- | src/qml/qml/qqmlbinding.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/qml/qml/qqmlbinding.cpp b/src/qml/qml/qqmlbinding.cpp index 91fa2aa7bd..a65f495293 100644 --- a/src/qml/qml/qqmlbinding.cpp +++ b/src/qml/qml/qqmlbinding.cpp @@ -137,14 +137,14 @@ QQmlBinding::QQmlBinding(const QString &str, QObject *obj, v4function.set(v4, qmlBinding(ctxt, obj, str, url, lineNumber)); } -QQmlBinding::QQmlBinding(const QV4::ValueRef functionPtr, QObject *obj, QQmlContextData *ctxt) +QQmlBinding::QQmlBinding(const QV4::Value &functionPtr, QObject *obj, QQmlContextData *ctxt) : QQmlJavaScriptExpression(&QQmlBinding_jsvtable), QQmlAbstractBinding(Binding) { setNotifyOnValueChanged(true); QQmlAbstractExpression::setContext(ctxt); setScopeObject(obj); - v4function.set(functionPtr->asObject()->engine(), functionPtr); + v4function.set(functionPtr.asObject()->engine(), functionPtr); } QQmlBinding::~QQmlBinding() |