diff options
author | Simon Hausmann <simon.hausmann@qt.io> | 2020-03-23 14:54:00 +0100 |
---|---|---|
committer | Simon Hausmann <simon.hausmann@qt.io> | 2020-03-23 15:01:53 +0100 |
commit | 67b73ad00904981d001bd752feae39b73407c103 (patch) | |
tree | 746abcbff6adbd340e8943f12660ca160601ea94 /src/qml/qml/qqmlbinding.cpp | |
parent | 619dfbe8d02347cedb93a949cde627ec4424e0ae (diff) |
Minor cleanup in QQmlJavaScriptExpression
We _can_ provide a default implementation for expressionIdentifier() -
it doesn't have to be located in QQmlBinding as it only uses fields from
QQmlJavaScriptExpression.
Change-Id: Ifcead72c4f3ed4597cde732afca466eba83f5e0d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/qml/qml/qqmlbinding.cpp')
-rw-r--r-- | src/qml/qml/qqmlbinding.cpp | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/qml/qml/qqmlbinding.cpp b/src/qml/qml/qqmlbinding.cpp index e8e57eb725..feb3fa9623 100644 --- a/src/qml/qml/qqmlbinding.cpp +++ b/src/qml/qml/qqmlbinding.cpp @@ -535,18 +535,6 @@ QVariant QQmlBinding::evaluate() return scope.engine->toVariant(result, qMetaTypeId<QList<QObject*> >()); } -QString QQmlBinding::expressionIdentifier() const -{ - if (auto f = function()) { - QString url = f->sourceFile(); - uint lineNumber = f->compiledFunction->location.line; - uint columnNumber = f->compiledFunction->location.column; - return url + QString::asprintf(":%u:%u", lineNumber, columnNumber); - } - - return QStringLiteral("[native code]"); -} - void QQmlBinding::expressionChanged() { update(); |