Fix memory leak in QQmlComponent::createObject

Regression introduced with 5.3.0. Prevent the leak of the object creator
on repeated createObject calls by using a scoped pointer.

Change-Id: Ib4fe7c9c6926c2390f7ae78f3287bb7da5f60527
Task-number: QTBUG-39742
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/src/qml/qml/qqmlcomponent_p.h b/src/qml/qml/qqmlcomponent_p.h
index e8ae540148..2c70d7b100 100644
--- a/src/qml/qml/qqmlcomponent_p.h
+++ b/src/qml/qml/qqmlcomponent_p.h
@@ -106,15 +106,13 @@ public:
 
     struct ConstructionState {
         ConstructionState()
-            : creator(0)
-            , completePending(false)
+            : completePending(false)
         {}
         ~ConstructionState()
         {
-            delete creator;
         }
 
-        QQmlObjectCreator *creator;
+        QScopedPointer<QQmlObjectCreator> creator;
         QList<QQmlError> errors;
         bool completePending;
     };