Minor cleanup in QQmlJavaScriptExpression

We _can_ provide a default implementation for expressionIdentifier() -
it doesn't have to be located in QQmlBinding as it only uses fields from
QQmlJavaScriptExpression.

Change-Id: Ifcead72c4f3ed4597cde732afca466eba83f5e0d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>

1 files changed, 12 insertions, 0 deletions

diff --git a/src/qml/qml/qqmljavascriptexpression.cpp b/src/qml/qml/qqmljavascriptexpression.cpp
index 93af2d7c52..3e204c1898 100644
--- a/src/qml/qml/qqmljavascriptexpression.cpp
+++ b/src/qml/qml/qqmljavascriptexpression.cpp
@@ -115,6 +115,18 @@ QQmlJavaScriptExpression::~QQmlJavaScriptExpression()
         m_scopeObject.asT2()->_s = nullptr;
 }
 
+QString QQmlJavaScriptExpression::expressionIdentifier() const
+{
+    if (auto f = function()) {
+        QString url = f->sourceFile();
+        uint lineNumber = f->compiledFunction->location.line;
+        uint columnNumber = f->compiledFunction->location.column;
+        return url + QString::asprintf(":%u:%u", lineNumber, columnNumber);
+    }
+
+    return QStringLiteral("[native code]");
+}
+
 void QQmlJavaScriptExpression::setNotifyOnValueChanged(bool v)
 {
     activeGuards.setFlagValue(v);