aboutsummaryrefslogtreecommitdiffstats
path: root/src/qml/qml/qqmlstringconverters.cpp
diff options
context:
space:
mode:
authorUlf Hermann <ulf.hermann@qt.io>2020-09-18 16:34:11 +0200
committerUlf Hermann <ulf.hermann@qt.io>2020-09-23 14:54:47 +0200
commit2d02307e73b63c8d2ce935a9d7dd7b177c017f87 (patch)
tree8751f6c3354d24bd4f13182e5178a98b8fca0263 /src/qml/qml/qqmlstringconverters.cpp
parent39b5be920cf65979df669d02a3410a7396be6ada (diff)
Condense the different value type creation functions into one
They all did the same thing. Change-Id: I7661b19ad16c0713d46c4df337899e3897349b2e Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/qml/qml/qqmlstringconverters.cpp')
-rw-r--r--src/qml/qml/qqmlstringconverters.cpp9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/qml/qml/qqmlstringconverters.cpp b/src/qml/qml/qqmlstringconverters.cpp
index 74dd5f431c..c7c111a052 100644
--- a/src/qml/qml/qqmlstringconverters.cpp
+++ b/src/qml/qml/qqmlstringconverters.cpp
@@ -75,8 +75,13 @@ QVariant QQmlStringConverters::variantFromString(const QString &s, int preferred
return QVariant::fromValue(rectFFromString(s, ok));
case QMetaType::QRect:
return QVariant::fromValue(rectFFromString(s, ok).toRect());
- default:
- return QQml_valueTypeProvider()->createVariantFromJsObject(preferredType, QJSValue(s), ok);
+ default: {
+ QVariant ret;
+ bool success = QQml_valueTypeProvider()->createValueType(preferredType, QJSValue(s), &ret);
+ if (ok)
+ *ok = success;
+ return ret;
+ }
}
}