diff options
| author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-15 15:31:00 +0300 |
|---|---|---|
| committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-18 07:53:43 +0000 |
| commit | f4d1a471bb87dd4d4bb79b10e8dc434d707711bd (patch) | |
| tree | c7ac9009009a293abb88bdf95533c39fca714128 /src/qml/qml/qqmltypeloader.cpp | |
| parent | 9e980750c6647ffcf2cb95e95e63fa8335924866 (diff) | |
Qml: fix expensive iteration over QHash::keys() and QMap::keys()
Change-Id: I7bb5dd3b49b9f3a638f81156a02d999dbbd932f3
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
Diffstat (limited to 'src/qml/qml/qqmltypeloader.cpp')
| -rw-r--r-- | src/qml/qml/qqmltypeloader.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/qml/qml/qqmltypeloader.cpp b/src/qml/qml/qqmltypeloader.cpp index 10be80ed0c..30a4512654 100644 --- a/src/qml/qml/qqmltypeloader.cpp +++ b/src/qml/qml/qqmltypeloader.cpp @@ -2225,7 +2225,10 @@ void QQmlTypeData::allDependenciesDone() for ( ; it != end; ++it) { if (*it == 0) { // This import was not resolved - foreach (const QV4::CompiledData::Import *import, m_unresolvedImports.keys()) { + for (auto keyIt = m_unresolvedImports.keyBegin(), + keyEnd = m_unresolvedImports.keyEnd(); + keyIt != keyEnd; ++keyIt) { + const QV4::CompiledData::Import *import = *keyIt; QQmlError error; error.setDescription(QQmlTypeLoader::tr("module \"%1\" is not installed").arg(stringAt(import->uriIndex))); error.setUrl(m_importCache.baseUrl()); |