diff options
| author | Simon Hausmann <simon.hausmann@qt.io> | 2018-04-24 10:20:42 +0200 |
|---|---|---|
| committer | Simon Hausmann <simon.hausmann@qt.io> | 2018-04-26 09:56:49 +0000 |
| commit | f741956de935ab9f954afa53b32a167c0c7528ea (patch) | |
| tree | 84bb99f97020f2b750d355325a6398e44e36dfeb /src/qml/qml/qqmltypeloader_p.h | |
| parent | 12a2c68789918637f7c28ef0b06d9e70b5fae0ca (diff) | |
Clean up manual reference counting of blob dependencies
The manual addref() and then release() in notifyComplete() are hard to
read. It's simpler to let m_waitingFor store QQmlRefPointer instances,
at the expense of iteration code that's harer to read.
Change-Id: Idc51fbb1b24e0bd466381b9a1ad10fbd38fc8ac1
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'src/qml/qml/qqmltypeloader_p.h')
| -rw-r--r-- | src/qml/qml/qqmltypeloader_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qml/qml/qqmltypeloader_p.h b/src/qml/qml/qqmltypeloader_p.h index 11e211012d..2418f3f716 100644 --- a/src/qml/qml/qqmltypeloader_p.h +++ b/src/qml/qml/qqmltypeloader_p.h @@ -217,7 +217,7 @@ private: QList<QQmlDataBlob *> m_waitingOnMe; // List of QQmlDataBlob's that I am waiting for to complete. - QList<QQmlDataBlob *> m_waitingFor; + QVector<QQmlRefPointer<QQmlDataBlob>> m_waitingFor; int m_redirectCount:30; bool m_inCallback:1; |