diff options
| author | Martin Jones <martin.jones@nokia.com> | 2012-05-28 15:32:11 +1000 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2012-05-29 04:37:01 +0200 |
| commit | 4285a99b14f05b604c266fdd33cf8edff7ff3ef3 (patch) | |
| tree | c506b7dfa018ef51146c7c60defa12264c172c4d /src/qml/qml/qqmlvaluetype.cpp | |
| parent | 0e75b2568d706759aa4818d8af9131ed645b65b8 (diff) | |
Fix potential buffer overrun.
Found by static analysis. operator[]() accepts index up to
QVariant::UserType-1 but only QVariant::UserType-1 were allocated.
Change-Id: I0691fe268e3ba029441e43bdfcd191400ea21f38
Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
Diffstat (limited to 'src/qml/qml/qqmlvaluetype.cpp')
| -rw-r--r-- | src/qml/qml/qqmlvaluetype.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/qml/qml/qqmlvaluetype.cpp b/src/qml/qml/qqmlvaluetype.cpp index 4086caee8d..b96c2f65a4 100644 --- a/src/qml/qml/qqmlvaluetype.cpp +++ b/src/qml/qml/qqmlvaluetype.cpp @@ -49,13 +49,13 @@ QT_BEGIN_NAMESPACE QQmlValueTypeFactory::QQmlValueTypeFactory() { - for (unsigned int ii = 0; ii < (QVariant::UserType - 1); ++ii) + for (unsigned int ii = 0; ii < QVariant::UserType; ++ii) valueTypes[ii] = 0; } QQmlValueTypeFactory::~QQmlValueTypeFactory() { - for (unsigned int ii = 0; ii < (QVariant::UserType - 1); ++ii) + for (unsigned int ii = 0; ii < QVariant::UserType; ++ii) delete valueTypes[ii]; } |